feat(github_ip_ranges): support for Web and API IP Ranges#1220
Merged
kfcampbell merged 4 commits intointegrations:mainfrom Aug 30, 2022
Merged
feat(github_ip_ranges): support for Web and API IP Ranges#1220kfcampbell merged 4 commits intointegrations:mainfrom
kfcampbell merged 4 commits intointegrations:mainfrom
Conversation
Contributor
|
Hmm, looks like |
kfcampbell
reviewed
Aug 11, 2022
kfcampbell
approved these changes
Aug 30, 2022
Contributor
kfcampbell
left a comment
There was a problem hiding this comment.
I've locally confirmed acceptance testing is passing. Thank you for the contributions! This functionality will be released this week.
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
…ns#1220) * feat(github_ip_ranges): support for web and api CIDR blocks from meta API. * fix: Api --> API as per sdk changes. Re-adding accidentally removed Pages. Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ns#1220) * feat(github_ip_ranges): support for web and api CIDR blocks from meta API. * fix: Api --> API as per sdk changes. Re-adding accidentally removed Pages. Co-authored-by: Keegan Campbell <me@kfcampbell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the following attributes to the
github_ip_rangesdata resource:webweb_ipv4web_ipv6apiapi_ipv4api_ipv6Somebody else had an old PR for this here - #483 which was blocked pending GraphQL API support.