Add "web" and "api" IP blocks published by GitHub#483
Closed
fabiendelpierre wants to merge 2 commits intointegrations:mainfrom
fabiendelpierre:github-api-and-web-ip-ranges
Closed
Add "web" and "api" IP blocks published by GitHub#483fabiendelpierre wants to merge 2 commits intointegrations:mainfrom fabiendelpierre:github-api-and-web-ip-ranges
fabiendelpierre wants to merge 2 commits intointegrations:mainfrom
fabiendelpierre:github-api-and-web-ip-ranges
Conversation
For some reason the "web" and "api" blocks published at https://api.github.com/meta are missing from the github_ip_ranges data source, this intends to remedy that.
Contributor
|
@fabiendelpierre thanks for getting this published for review. This one makes sense for an upcoming feature release. It is now tracked for further testing. |
Contributor
|
🤔 our underlying library does not have support for this and the GraphQL API is also not showing support for the My recommendation is we wait on better support for this data and will ask internally to get clarity on when we can expect these fields to be visible in the GraphQL API. |
|
It would be great if the "actions" IP ranges could be incorporated into this PR when the underlying hurdles are removed. Like the others it should be similarly simple if the library support is there. See #351 |
Contributor
|
Closing in favor of #1220. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the "web" and "api" blocks published at https://api.github.com/meta are missing from the github_ip_ranges data source, this intends to remedy that. I'm not sure why they aren't included in the first place.
Also... I don't code in GoLang and lack the tooling as well as the ability to test this locally, but it seemed easy enough to add the bits of code needed for this PR. Which is to say, I hope this looks OK and I didn't miss anything.