Skip to content

Fix docker-image make target#8005

Merged
reimda merged 1 commit intoinfluxdata:masterfrom
SumoLogic:fix-docker-image-target
Sep 3, 2020
Merged

Fix docker-image make target#8005
reimda merged 1 commit intoinfluxdata:masterfrom
SumoLogic:fix-docker-image-target

Conversation

@pmalek-sumo
Copy link
Copy Markdown
Contributor

@pmalek-sumo pmalek-sumo commented Aug 19, 2020

COMMIT doesn't seem to be defined anywhere which causes:

docker build -f scripts/stretch.docker -t "telegraf:" .
invalid argument "telegraf:" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
make: *** [docker-image] Error 125

whereas commit is defined in https://github.com/influxdata/telegraf/blob/master/Makefile#L10

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@pmalek-sumo pmalek-sumo changed the title Fix docker-image make target (#2) Fix docker-image make target Aug 19, 2020
@sjwang90
Copy link
Copy Markdown
Contributor

sjwang90 commented Aug 25, 2020

Thanks for the contribution. We'll take a look at the PR and let you know if we have any comments.

@pmalek-sumo
Copy link
Copy Markdown
Contributor Author

pmalek-sumo commented Aug 26, 2020

Actually I'm not sure if we'd like to keep maintaining this as the make target that is referred in scripts/stretch.docker: go-install doesn't exist in the repo anymore.

It was removed in #7759.

Maybe we should just remove the remnants of the previous build scripts/targets?

@reimda
Copy link
Copy Markdown
Contributor

reimda commented Sep 3, 2020

Thanks for the PR.

#8051 restored the go-install make target, so this fix is useful.

@reimda reimda merged commit 843ea4b into influxdata:master Sep 3, 2020
@pmalek-sumo pmalek-sumo deleted the fix-docker-image-target branch September 3, 2020 15:40
@sjwang90 sjwang90 added this to the 1.15.3 milestone Sep 3, 2020
ssoroka pushed a commit that referenced this pull request Sep 11, 2020
@pmalek-sumo @ssoroka
Fix docker-image make target (#8005)
c34ef64
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@pmalek-sumo
Fix docker-image make target (influxdata#8005)
665c5b1
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@pmalek-sumo
Fix docker-image make target (influxdata#8005)
a5206e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.15.3

Development

Successfully merging this pull request may close these issues.

3 participants

@pmalek-sumo @sjwang90 @reimda