Skip to content

Build packages in makefile#7759

Merged
danielnelson merged 1 commit intomasterfrom
remove-build-py
Jun 30, 2020
Merged

Build packages in makefile#7759
danielnelson merged 1 commit intomasterfrom
remove-build-py

Conversation

@danielnelson
Copy link
Copy Markdown
Contributor

Removed build.py and replaced with Makefile targets.

  • Split deb and rpm maintainer scripts.
  • Move release upload into scripts/release.sh with signing (except for nightly uploads).
  • Added version to package top-level directory.
  • Fix rpm config to be overwritten on update.

closes: #7389
closes: #7396

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson requested a review from ssoroka June 29, 2020 17:01
@danielnelson danielnelson added this to the 1.15.0 milestone Jun 29, 2020
Copy link
Copy Markdown
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Net improvement, for sure. Happy to get rid of the python dep, not super excited about so much Makefile code, but it seems like the right place for it.

@danielnelson danielnelson merged commit b6560c8 into master Jun 30, 2020
@danielnelson danielnelson deleted the remove-build-py branch June 30, 2020 07:15
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
@pmalek-sumo pmalek-sumo mentioned this pull request Aug 26, 2020
3 tasks
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packaging] directory within Telegraf.zip file for Windows needs a version Updating to 1.15 rpm nightly build overwrites configuration file

2 participants