fix docker build. update dockerfiles to Go 1.14#8051
Merged
Conversation
reimda
approved these changes
Aug 28, 2020
ssoroka
added a commit
that referenced
this pull request
Aug 29, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
make go-installshould probably not have been removed, as it was still in use. Likely daniel thought that it was not relevant to the new makefile setup, which focuses on creating our package builds, however the docker file also expects to be able to call into it so it doesn't have to manage env variables. This is likely a reasonable assumption, and not realistic to expect only one consumer of theMakefile, so I've added the function back in.