Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: guptarohit/mfp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.1
Choose a base ref
...
head repository: guptarohit/mfp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.2
Choose a head ref
  • 4 commits
  • 7 files changed
  • 2 contributors

Commits on Mar 14, 2026

  1. fix: avoid file#label syntax in gh release upload for Linux compatibi… 

    …lity

Copy binary to final asset name before uploading to avoid the `#`
separator format which fails on ubuntu-latest runners.
    @guptarohit
    guptarohit committed Mar 14, 2026
    Configuration menu
    Copy the full SHA
    01c69ee View commit details
    Browse the repository at this point in the history

  2. fix: songs cut off early when RSS duration is shorter than actual audio 

    Remove the hard stop that killed playback when display_position exceeded
audio_duration_sec (sourced from RSS itunes:duration metadata). Playback
now ends only when the decoder reaches true EOF (sink.empty()) or the
user quits. Progress bar is clamped to audio_duration_sec to prevent
visual overflow on episodes where actual audio exceeds RSS metadata.

Fixes #1
    @guptarohit
    guptarohit committed Mar 14, 2026
    Configuration menu
    Copy the full SHA
    2f2e88b View commit details
    Browse the repository at this point in the history

  3. fix: songs cut off early when RSS duration is shorter than actual aud… 

    …io (#21)

## Problem

  Songs stop playing before they finish when the RSS `itunes:duration`
metadata is shorter than the actual MP3 audio length. The playback loop
  had a hard stop condition that fired as soon as `display_position`
  exceeded `audio_duration_sec`, killing the audio prematurely.

  ## Fix

Remove the hard stop (`if display_position >= audio_duration_sec {
break; }`).
  Playback now ends only when:
  - The decoder reaches true end-of-stream (`sink.empty()`)
  - The user presses `q`
  - The user seeks past the end

  The progress bar display is clamped to `audio_duration_sec` so it
  doesn't visually overflow past 100% on episodes where actual audio
  exceeds RSS metadata duration.

  Fixes #1
    @guptarohit
    guptarohit authored Mar 14, 2026
    Configuration menu
    Copy the full SHA
    f73f532 View commit details
    Browse the repository at this point in the history

  4. chore: release 0.3.2 (#20) 

    🤖 I have created a release *beep* *boop*
---


## [0.3.2](v0.3.1...v0.3.2)
(2026-03-14)


### Fixed

* avoid file#label syntax in gh release upload for Linux compatibility
([01c69ee](01c69ee))
* songs cut off early when RSS duration is shorter than actual audio
([2f2e88b](2f2e88b)),
closes [#1](#1)


---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
    @guptarohit
    guptarohit authored Mar 14, 2026
    Configuration menu
    Copy the full SHA
    a38ad41 View commit details
    Browse the repository at this point in the history
Loading