Skip to content

Commit 01c69ee

Browse files
committed
fix: avoid file#label syntax in gh release upload for Linux compatibility
Copy binary to final asset name before uploading to avoid the `#` separator format which fails on ubuntu-latest runners.
1 parent 1b2bc5a commit 01c69ee

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/rebuild-release-assets.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,9 @@ jobs:
6868
run: |
6969
VERSION="${{ inputs.tag }}"
7070
VERSION="${VERSION#v}"
71-
gh release upload --clobber "${{ inputs.tag }}" \
72-
"target/${{ matrix.target }}/release/mfp${{ env.EXE }}#mfp-${VERSION}-${{ matrix.artifact-name }}${{ env.EXE }}"
71+
ASSET="mfp-${VERSION}-${{ matrix.artifact-name }}${{ env.EXE }}"
72+
cp "target/${{ matrix.target }}/release/mfp${{ env.EXE }}" "${ASSET}"
73+
gh release upload --clobber "${{ inputs.tag }}" "${ASSET}"
7374
shell: bash
7475

7576
publish-crate:

.github/workflows/release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,9 @@ jobs:
8181
env:
8282
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8383
run: |
84-
gh release upload --clobber ${{ needs.release-please.outputs.tag_name }} \
85-
"target/${{ matrix.target }}/release/mfp${{ env.EXE }}#mfp-${{ needs.release-please.outputs.version }}-${{ matrix.artifact-name }}${{ env.EXE }}"
84+
ASSET="mfp-${{ needs.release-please.outputs.version }}-${{ matrix.artifact-name }}${{ env.EXE }}"
85+
cp "target/${{ matrix.target }}/release/mfp${{ env.EXE }}" "${ASSET}"
86+
gh release upload --clobber ${{ needs.release-please.outputs.tag_name }} "${ASSET}"
8687
shell: bash
8788

8889
publish-crate:

0 commit comments

Comments
 (0)