fix: songs cut off early when RSS duration is shorter than actual audio#21
Merged
guptarohit merged 1 commit intomainfrom Mar 14, 2026
Merged
fix: songs cut off early when RSS duration is shorter than actual audio#21guptarohit merged 1 commit intomainfrom
guptarohit merged 1 commit intomainfrom
Conversation
Remove the hard stop that killed playback when display_position exceeded audio_duration_sec (sourced from RSS itunes:duration metadata). Playback now ends only when the decoder reaches true EOF (sink.empty()) or the user quits. Progress bar is clamped to audio_duration_sec to prevent visual overflow on episodes where actual audio exceeds RSS metadata. Fixes #1
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Songs stop playing before they finish when the RSS
itunes:durationmetadata is shorter than the actual MP3 audio length. The playback loop
had a hard stop condition that fired as soon as
display_positionexceeded
audio_duration_sec, killing the audio prematurely.Fix
Remove the hard stop (
if display_position >= audio_duration_sec { break; }).Playback now ends only when:
sink.empty())qThe progress bar display is clamped to
audio_duration_secso itdoesn't visually overflow past 100% on episodes where actual audio
exceeds RSS metadata duration.
Fixes #1