[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil (v1.62.x backport)#36376
Merged
XuanWang-Amos merged 1 commit intogrpc:v1.62.xfrom Apr 16, 2024
Conversation
…th nogil (grpc#36266) This fix is similar to grpc#34712 but for `grpc_google_default_credentials_create` rather than `grpc_ssl_credentials_create` Fixes grpc#36265 Fixes googleapis/python-bigtable#949 Closes grpc#36266 COPYBARA_INTEGRATE_REVIEW=grpc#36266 from parthea:repro-issue-34672 d736f6f PiperOrigin-RevId: 623291826
eugeneo
approved these changes
Apr 16, 2024
Contributor
eugeneo
left a comment
There was a problem hiding this comment.
Just to confirm - is src/python/grpcio/grpc/_cython/_cygrpc/credentials.pyx.pxi an actual file that needs to be edited? Path starting with underscores makes it look like a generated file.
Contributor
Author
Yes, that's a manually edited file. Underscore in Python means it's a private file. |
holtskinner
referenced
this pull request
in GoogleCloudPlatform/generative-ai
Apr 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [grpcio](https://grpc.io) ([source](https://togithub.com/grpc/grpc)) | `==1.62.1` -> `==1.62.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc (grpcio)</summary> ### [`v1.62.2`](https://togithub.com/grpc/grpc/releases/tag/v1.62.2) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.1...v1.62.2) This is release gRPC Core 1.62.2 (guardian). For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes. ## Python - \[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil by [@​XuanWang-Amos](https://togithub.com/XuanWang-Amos) in [https://github.com/grpc/grpc/pull/36376](https://togithub.com/grpc/grpc/pull/36376) **Full Changelog**: grpc/grpc@v1.62.1...v1.62.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GoogleCloudPlatform/generative-ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-pb-python
May 1, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [grpcio](https://grpc.io) ([source](https://togithub.com/grpc/grpc)) | minor | `==1.62.1` -> `==1.63.0` | --- ### Release Notes <details> <summary>grpc/grpc (grpcio)</summary> ### [`v1.63.0`](https://togithub.com/grpc/grpc/releases/tag/v1.63.0) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.2...v1.63.0) This is release 1.63.0 ([giggle](https://togithub.com/grpc/grpc/blob/master/doc/g_stands_for.md)) of gRPC Core. For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes, with highlights listed below. ## Core - \[Deps] Backport: Protobuf upgrade to v26.1. ([#​36353](https://togithub.com/grpc/grpc/pull/36353)) - \[OTel C++] Add experimental optional locality label available to client per-attempt metrics. ([#​36254](https://togithub.com/grpc/grpc/pull/36254)) - \[surface] Add an API to inject connected endpoints into servers. ([#​35957](https://togithub.com/grpc/grpc/pull/35957)) - \[CMake] Add gRPC_USE_SYSTEMD option. ([#​34384](https://togithub.com/grpc/grpc/pull/34384)) - \[OTel C++] Add API to set channel scope filter. ([#​36189](https://togithub.com/grpc/grpc/pull/36189)) - \[Deps] Upgraded protobuf to v26.1. ([#​35796](https://togithub.com/grpc/grpc/pull/35796)) - \[channel] canonify target and set channel arg in only one place. ([#​36134](https://togithub.com/grpc/grpc/pull/36134)) - \[grpc]\[Gpr_To_Absl_Logging] Using absl from within gpr logging. ([#​36108](https://togithub.com/grpc/grpc/pull/36108)) - \[BoringSSL] Update third_party/boringssl-with-bazel. ([#​36089](https://togithub.com/grpc/grpc/pull/36089)) - \[EventEngine] Document RunAfter can return an invalid handle for immediate execution. ([#​36072](https://togithub.com/grpc/grpc/pull/36072)) - \[EventEngine] Enable the EventEngine DNS Resolver on Posix. ([#​35573](https://togithub.com/grpc/grpc/pull/35573)) - \[EventEngine] Support AF_UNIX for windows. ([#​34801](https://togithub.com/grpc/grpc/pull/34801)) ## C++ - \[OTel C++] Add APIs to enable/disable metrics. ([#​36183](https://togithub.com/grpc/grpc/pull/36183)) - \[EventEngine] Refactor ServerCallbackCall to use EventEngine::Run. ([#​36126](https://togithub.com/grpc/grpc/pull/36126)) - \[OTel C++] Add CMake build support. ([#​36063](https://togithub.com/grpc/grpc/pull/36063)) - gRPC C++ upgraded Protobuf to v26.1. ([#​36323](https://togithub.com/grpc/grpc/pull/36323)) ## C\# - \[csharp] Fix csharp doc comments. ([#​36000](https://togithub.com/grpc/grpc/pull/36000)) - C#: Grpc.Tools: Handle regex timeout when parsing protoc output. ([#​36185](https://togithub.com/grpc/grpc/pull/36185)) ## PHP - Update min PHP testing version from PHP 7.4 to 8.1. ([#​35964](https://togithub.com/grpc/grpc/pull/35964)) ## Python - \[Python Version] Drop support for Python 3.7. ([#​34450](https://togithub.com/grpc/grpc/pull/34450)) - \[Python Aio] Change aio Metadata inheritance. ([#​36214](https://togithub.com/grpc/grpc/pull/36214)) - \[Documentation] fix asyncio Server and Channel stop() method documentation. ([#​35946](https://togithub.com/grpc/grpc/pull/35946)) - \[Python O11y] Change public interface. ([#​36094](https://togithub.com/grpc/grpc/pull/36094)) - \[Python Stub] Add version check to stubs generated by grpcio_tools. ([#​35906](https://togithub.com/grpc/grpc/pull/35906)) - \[AbortError] Reapply "\[AbortError] And and check AbortError while abort". ([#​34525](https://togithub.com/grpc/grpc/pull/34525)) - \[Build Reproducibility] Sort input file list. ([#​35687](https://togithub.com/grpc/grpc/pull/35687)) - \[Python O11Y] Reapply registered method change. ([#​35850](https://togithub.com/grpc/grpc/pull/35850)) - \[Python Modernization] Deprecate pkg_resources. ([#​35849](https://togithub.com/grpc/grpc/pull/35849)) - \[Python Bazel] Allow overwriting grpc_library in python_rules.bzl. ([#​35629](https://togithub.com/grpc/grpc/pull/35629)) ## Ruby - ruby: register grpc_rb_sStatus as a global variable. ([#​36125](https://togithub.com/grpc/grpc/pull/36125)) ### [`v1.62.2`](https://togithub.com/grpc/grpc/releases/tag/v1.62.2) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.1...v1.62.2) This is release gRPC Core 1.62.2 (guardian). For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes. ## Python - \[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil by [@​XuanWang-Amos](https://togithub.com/XuanWang-Amos) in [https://github.com/grpc/grpc/pull/36376](https://togithub.com/grpc/grpc/pull/36376) **Full Changelog**: grpc/grpc@v1.62.1...v1.62.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-sdk-python
May 1, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [grpcio](https://grpc.io) ([source](https://togithub.com/grpc/grpc)) | minor | `==1.62.1` -> `==1.63.0` | --- ### Release Notes <details> <summary>grpc/grpc (grpcio)</summary> ### [`v1.63.0`](https://togithub.com/grpc/grpc/releases/tag/v1.63.0) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.2...v1.63.0) This is release 1.63.0 ([giggle](https://togithub.com/grpc/grpc/blob/master/doc/g_stands_for.md)) of gRPC Core. For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes, with highlights listed below. ## Core - \[Deps] Backport: Protobuf upgrade to v26.1. ([#​36353](https://togithub.com/grpc/grpc/pull/36353)) - \[OTel C++] Add experimental optional locality label available to client per-attempt metrics. ([#​36254](https://togithub.com/grpc/grpc/pull/36254)) - \[surface] Add an API to inject connected endpoints into servers. ([#​35957](https://togithub.com/grpc/grpc/pull/35957)) - \[CMake] Add gRPC_USE_SYSTEMD option. ([#​34384](https://togithub.com/grpc/grpc/pull/34384)) - \[OTel C++] Add API to set channel scope filter. ([#​36189](https://togithub.com/grpc/grpc/pull/36189)) - \[Deps] Upgraded protobuf to v26.1. ([#​35796](https://togithub.com/grpc/grpc/pull/35796)) - \[channel] canonify target and set channel arg in only one place. ([#​36134](https://togithub.com/grpc/grpc/pull/36134)) - \[grpc]\[Gpr_To_Absl_Logging] Using absl from within gpr logging. ([#​36108](https://togithub.com/grpc/grpc/pull/36108)) - \[BoringSSL] Update third_party/boringssl-with-bazel. ([#​36089](https://togithub.com/grpc/grpc/pull/36089)) - \[EventEngine] Document RunAfter can return an invalid handle for immediate execution. ([#​36072](https://togithub.com/grpc/grpc/pull/36072)) - \[EventEngine] Enable the EventEngine DNS Resolver on Posix. ([#​35573](https://togithub.com/grpc/grpc/pull/35573)) - \[EventEngine] Support AF_UNIX for windows. ([#​34801](https://togithub.com/grpc/grpc/pull/34801)) ## C++ - \[OTel C++] Add APIs to enable/disable metrics. ([#​36183](https://togithub.com/grpc/grpc/pull/36183)) - \[EventEngine] Refactor ServerCallbackCall to use EventEngine::Run. ([#​36126](https://togithub.com/grpc/grpc/pull/36126)) - \[OTel C++] Add CMake build support. ([#​36063](https://togithub.com/grpc/grpc/pull/36063)) - gRPC C++ upgraded Protobuf to v26.1. ([#​36323](https://togithub.com/grpc/grpc/pull/36323)) ## C\# - \[csharp] Fix csharp doc comments. ([#​36000](https://togithub.com/grpc/grpc/pull/36000)) - C#: Grpc.Tools: Handle regex timeout when parsing protoc output. ([#​36185](https://togithub.com/grpc/grpc/pull/36185)) ## PHP - Update min PHP testing version from PHP 7.4 to 8.1. ([#​35964](https://togithub.com/grpc/grpc/pull/35964)) ## Python - \[Python Version] Drop support for Python 3.7. ([#​34450](https://togithub.com/grpc/grpc/pull/34450)) - \[Python Aio] Change aio Metadata inheritance. ([#​36214](https://togithub.com/grpc/grpc/pull/36214)) - \[Documentation] fix asyncio Server and Channel stop() method documentation. ([#​35946](https://togithub.com/grpc/grpc/pull/35946)) - \[Python O11y] Change public interface. ([#​36094](https://togithub.com/grpc/grpc/pull/36094)) - \[Python Stub] Add version check to stubs generated by grpcio_tools. ([#​35906](https://togithub.com/grpc/grpc/pull/35906)) - \[AbortError] Reapply "\[AbortError] And and check AbortError while abort". ([#​34525](https://togithub.com/grpc/grpc/pull/34525)) - \[Build Reproducibility] Sort input file list. ([#​35687](https://togithub.com/grpc/grpc/pull/35687)) - \[Python O11Y] Reapply registered method change. ([#​35850](https://togithub.com/grpc/grpc/pull/35850)) - \[Python Modernization] Deprecate pkg_resources. ([#​35849](https://togithub.com/grpc/grpc/pull/35849)) - \[Python Bazel] Allow overwriting grpc_library in python_rules.bzl. ([#​35629](https://togithub.com/grpc/grpc/pull/35629)) ## Ruby - ruby: register grpc_rb_sStatus as a global variable. ([#​36125](https://togithub.com/grpc/grpc/pull/36125)) ### [`v1.62.2`](https://togithub.com/grpc/grpc/releases/tag/v1.62.2) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.1...v1.62.2) This is release gRPC Core 1.62.2 (guardian). For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes. ## Python - \[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil by [@​XuanWang-Amos](https://togithub.com/XuanWang-Amos) in [https://github.com/grpc/grpc/pull/36376](https://togithub.com/grpc/grpc/pull/36376) **Full Changelog**: grpc/grpc@v1.62.1...v1.62.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMzMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
kartikeygupta24
referenced
this pull request
in nitchandak/generative-ai
May 3, 2024
…#584) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [grpcio](https://grpc.io) ([source](https://togithub.com/grpc/grpc)) | `==1.62.1` -> `==1.62.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc (grpcio)</summary> ### [`v1.62.2`](https://togithub.com/grpc/grpc/releases/tag/v1.62.2) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.1...v1.62.2) This is release gRPC Core 1.62.2 (guardian). For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes. ## Python - \[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil by [@​XuanWang-Amos](https://togithub.com/XuanWang-Amos) in [https://github.com/grpc/grpc/pull/36376](https://togithub.com/grpc/grpc/pull/36376) **Full Changelog**: grpc/grpc@v1.62.1...v1.62.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GoogleCloudPlatform/generative-ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
zeroasterisk
referenced
this pull request
in zeroasterisk/generative-ai
Jul 4, 2024
…#584) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [grpcio](https://grpc.io) ([source](https://togithub.com/grpc/grpc)) | `==1.62.1` -> `==1.62.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc (grpcio)</summary> ### [`v1.62.2`](https://togithub.com/grpc/grpc/releases/tag/v1.62.2) [Compare Source](https://togithub.com/grpc/grpc/compare/v1.62.1...v1.62.2) This is release gRPC Core 1.62.2 (guardian). For gRPC documentation, see [grpc.io](https://grpc.io/). For previous releases, see [Releases](https://togithub.com/grpc/grpc/releases). This release contains refinements, improvements, and bug fixes. ## Python - \[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil by [@​XuanWang-Amos](https://togithub.com/XuanWang-Amos) in [https://github.com/grpc/grpc/pull/36376](https://togithub.com/grpc/grpc/pull/36376) **Full Changelog**: grpc/grpc@v1.62.1...v1.62.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GoogleCloudPlatform/generative-ai). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #36266 to v1.62.x.
This fix is similar to #34712 but for
grpc_google_default_credentials_createrather thangrpc_ssl_credentials_createFixes #36265
Fixes googleapis/python-bigtable#949