[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil#36266
Closed
parthea wants to merge 10 commits intogrpc:masterfrom
Closed
[Fix Python Deadlock] Guard grpc_google_default_credentials_create with nogil#36266parthea wants to merge 10 commits intogrpc:masterfrom
parthea wants to merge 10 commits intogrpc:masterfrom
Conversation
Contributor
Author
|
@XuanWang-Amos, I made another refactor to simplify the code. PTAL |
Contributor
|
Bazel RBE Non-Bazel Tests Failed, doesn't seems to be related to this PR: https://btx.cloud.google.com/invocations/8046d089-4961-4c95-b4b5-b53d69772331/targets. Re-triggering tests. |
XuanWang-Amos
approved these changes
Apr 9, 2024
Contributor
XuanWang-Amos
left a comment
There was a problem hiding this comment.
Tests looks good, thanks for the fix!
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
Apr 16, 2024
…th nogil (grpc#36266) This fix is similar to grpc#34712 but for `grpc_google_default_credentials_create` rather than `grpc_ssl_credentials_create` Fixes grpc#36265 Fixes googleapis/python-bigtable#949 Closes grpc#36266 COPYBARA_INTEGRATE_REVIEW=grpc#36266 from parthea:repro-issue-34672 d736f6f PiperOrigin-RevId: 623291826
XuanWang-Amos
added a commit
that referenced
this pull request
Apr 16, 2024
…th nogil (v1.62.x backport) (#36376) Backport of #36266 to v1.62.x. --- This fix is similar to #34712 but for `grpc_google_default_credentials_create` rather than `grpc_ssl_credentials_create` Fixes #36265 Fixes googleapis/python-bigtable#949 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is similar to #34712 but for
grpc_google_default_credentials_createrather thangrpc_ssl_credentials_createFixes #36265
Fixes googleapis/python-bigtable#949