[Build Reproducibility] Sort input file list#35687
Merged
veblush merged 2 commits intogrpc:masterfrom Feb 29, 2024
bmwiedemann:sort
Merged
[Build Reproducibility] Sort input file list#35687veblush merged 2 commits intogrpc:masterfrom bmwiedemann:sort
veblush merged 2 commits intogrpc:masterfrom
bmwiedemann:sort
Conversation
so that the .so file builds in a reproducible way in spite of non-deterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good. This patch was done while working on reproducible builds for openSUSE.
gnossen
approved these changes
Jan 30, 2024
Contributor
|
Thanks for the fix! |
veblush
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort input file list
so that the
.sofile builds in a reproducible wayin spite of non-deterministic filesystem readdir order and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.
This patch was done while working on reproducible builds for openSUSE.