[CMake] Add gRPC_USE_SYSTEMD option#34384
Closed
kirpichik wants to merge 1 commit intogrpc:masterfrom
Closed
Conversation
|
|
Contributor
Author
|
Issue: #34304 |
Member
|
Please sign the CLA |
Contributor
Author
|
Signed. |
Collaborator
|
More than 30 days have passed since label "disposition/requires reporter action" was added. Closing this issue. Please feel free to re-open/create a new issue if this is still relevant. |
Contributor
Author
|
Thank you for the patch. It resolves our issues in the cross-compilation build toolchain. |
|
Was it merged?... |
Contributor
Author
|
@AndreyMlashkin No, the bot closed this PR due to the inactivity of reviewers and I do not have the rights to reopen it. Not sure how else I can ping maintainers. |
Contributor
|
I'd prefer this option looks like; (mostly the same with different names)
|
Allows to disable systemd support, as well as linking with libsystemd, when it is not required. The option has three possible values: AUTO - Default, Will try to find libsystemd. If found, systemd support will be enabled. ON - Enable systemd support. Build will fail if libsystemd is not found. OFF - Disable systemd support.
24c997d to
96f5f4b
Compare
Contributor
Author
|
@veblush updated according to your preferences. |
yashykt
approved these changes
Mar 5, 2024
Contributor
Author
Member
|
yeah, sorry for the delay. Not sure what happened here. Let me see why this got stuck. |
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
This gives grpc_endpoint the same destruction-is-shutdown semantic as EventEngine::Endpoint, which will make the migration easier. COPYBARA_INTEGRATE_REVIEW=#34384 from kirpichik:cmake-use-systemd-option 96f5f4b FUTURE_COPYBARA_INTEGRATE_REVIEW=#34384 from kirpichik:cmake-use-systemd-option 96f5f4b ---- DO NOT SUBMIT. This PR is for testing purposes only. [cl/620101818](http://cl/620101818) [cl/621274356](http://cl/621274356) PiperOrigin-RevId: 620101818
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #34304
Allows to disable systemd support,
as well as linking with libsystemd,
when it is not required.
The option has three possible values:
AUTO - Default, Will try to find libsystemd. If found, systemd support will be enabled.
ON - Enable systemd support. Build will fail if libsystemd is not found.
OFF - Disable systemd support.