[EventEngine] Disable EventEngine polling in gRPC Python (#33279)#33320
Merged
veblush merged 1 commit intogrpc:v1.55.xfrom Jun 1, 2023
Merged
[EventEngine] Disable EventEngine polling in gRPC Python (#33279)#33320veblush merged 1 commit intogrpc:v1.55.xfrom
veblush merged 1 commit intogrpc:v1.55.xfrom
Conversation
This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's `poll` poller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until the `poll` poller is fixed.
veblush
approved these changes
Jun 1, 2023
gnossen
added a commit
that referenced
this pull request
Jun 2, 2023
Turns out this is needed in addition to #33320 to resolve the MacOS fork issues for Python. CC @sampajano Co-authored-by: AJ Heller <hork@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's
pollpoller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until thepollpoller is fixed.