[EventEngine] Disable EventEngine polling in gRPC Python#33279
Merged
drfloob merged 3 commits intogrpc:masterfrom May 31, 2023
Merged
[EventEngine] Disable EventEngine polling in gRPC Python#33279drfloob merged 3 commits intogrpc:masterfrom
drfloob merged 3 commits intogrpc:masterfrom
Conversation
gnossen
approved these changes
May 30, 2023
gnossen
approved these changes
May 30, 2023
Contributor
|
This will temporarily mitigate #33218 |
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Jun 1, 2023
This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's `poll` poller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until the `poll` poller is fixed.
gnossen
pushed a commit
to gnossen/grpc
that referenced
this pull request
Jun 1, 2023
This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's `poll` poller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until the `poll` poller is fixed.
veblush
pushed a commit
that referenced
this pull request
Jun 1, 2023
…3320) This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's `poll` poller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until the `poll` poller is fixed. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Co-authored-by: AJ Heller <hork@google.com>
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jun 15, 2023
This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's `poll` poller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until the `poll` poller is fixed.
veblush
pushed a commit
that referenced
this pull request
May 13, 2025
…INSTANTIATE_POSIX_POLLER build define in Bazel tests (#39346) The root cause of the ping timeout issue in Python that was recently reported by Dataflow as well as in issue #38282 was because Python has explicitly disabled the use of EventEngine polling using the `GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER` build flag (Reference: #33279). However, it was found that the issue could not be reproduced when running via Bazel. This was because the `GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER` flag was not getting propagated upstream to the Core layer, unless specifically defined as a compiler option in `tools/bazel.rc` or passed via command-line. Without this option, all the while the Python Bazel tests have been testing something different than those covered by the setup.py build. This PR hence does the following to fix the inconsistency: - Update `tools/bazel.rc` with a python specific compiler option that is included only when the specific `--config` command-line flag is included when running via Bazel - Updates Python Bazel tests to include the new config flag
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack to get around an issue on Apple devices caused by the PosixEventEngine's
pollpoller not supporting fork. This PR disables the EventEngine poller entirely in Python builds. It will therefore prevent the release of the EventEngine generally, and prevent any testing of EventEngine integration with gRPC Python, until thepollpoller is fixed.