Add new Python specific Bazel compiler option to include GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER build define in Bazel tests#39346
Merged
veblush merged 5 commits intogrpc:masterfrom May 13, 2025
Conversation
gnossen
requested changes
Apr 23, 2025
Contributor
gnossen
left a comment
There was a problem hiding this comment.
Let's separate this into three PRs:
- The Python repro (will not be merged)
- The C++ repro (will not be merged)
- The addition of the
pythonBazel config (will be merged)
Contributor
Author
Done, updated this PR to only include the Bazel config changes that can be merged. The C++ and Python repro codes have been separated into 2 Draft PRs: |
gnossen
approved these changes
Apr 28, 2025
sergiitk
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of the ping timeout issue in Python that was recently reported by Dataflow as well as in issue #38282 was because Python has explicitly disabled the use of EventEngine polling using the
GRPC_DO_NOT_INSTANTIATE_POSIX_POLLERbuild flag (Reference: #33279).However, it was found that the issue could not be reproduced when running via Bazel. This was because the
GRPC_DO_NOT_INSTANTIATE_POSIX_POLLERflag was not getting propagated upstream to the Core layer, unless specifically defined as a compiler option intools/bazel.rcor passed via command-line.Without this option, all the while the Python Bazel tests have been testing something different than those covered by the setup.py build.
This PR hence does the following to fix the inconsistency:
tools/bazel.rcwith a python specific compiler option that is included only when the specific--configcommand-line flag is included when running via Bazel