Support for prebuilt Ruby binary on x64-mingw-ucrt platform by johnnyshields · Pull Request #29684 · grpc/grpc

johnnyshields · 2022-05-13T15:28:52Z

Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

linux-foundation-easycla · 2022-05-13T15:28:54Z

The committers listed above are authorized under a signed CLA.

✅ login: johnnyshields / name: Johnny Shields (bb05366)

…h is used for Windows RubyInstaller Ruby 3.1+

johnnyshields · 2022-05-13T15:40:03Z

@apolcyn @nicolasnoble here's a draft of the mingw-ucrt build. The rake_compiler_dock image for mingw-ucrt does exist, so I believe this should be mostly a config change.

A naive attempt to build on my machine yields the following:

$ bundle exec rake gem:native plat=x64-mingw-ucrt

...
Unable to find image 'grpctesting/rake_x64-mingw-ucrt:7bdea71e6764cc6445851fb66bad35cd8efa7ac5' locally
docker: Error response from daemon: pull access denied for grpctesting/rake_x64-mingw-ucrt, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

If someone could take a moment to look at this it would be greatly appreciated. Worth noting that mingw-ucrt is the main/only supported Windows platform starting from Ruby 3.1.

linux-foundation-easycla · 2022-05-13T16:06:31Z

The committers listed above are authorized under a signed CLA.

✅ login: johnnyshields / name: Johnny Shields (bb05366, 3b60788)

nicolasnoble · 2022-05-13T16:22:37Z

Likely correct. I can quickly push that docker image for local testing, hang tight.

johnnyshields · 2022-05-13T16:25:16Z

Rakefile

  plat_list = args[:plat]

  build_configs = []
+  w64_ucrt = { cross: 'x86_64-w64-mingw32', out: 'grpc_c.64-ucrt.ruby', platform: 'x64-mingw-ucrt' }


AFAIK the rake-compiler-dock docker image for ucrt uses the same gcc/g++ packages as the x64-mingw image, and patches them to use ucrt runtime.

nicolasnoble · 2022-05-13T16:32:05Z

I've pushed the image, if you want to retry on your end.

johnnyshields · 2022-05-13T17:10:34Z

@nicolasnoble it worked! Was able to get a successful build. Would appreciate if the team could move forward with this PR.

Here's the artifact as evidence, ha well I know its a bit sketch to attach an untrusted binary 😆
grpc_c.64-ucrt.zip

nicolasnoble · 2022-05-13T17:25:53Z

Looks good to me, I'll let @apolcyn do the second review and merge :)

johnnyshields · 2022-05-13T17:32:09Z

Great, thanks! If it looks good, it would be wonderful if we could get a backport to v1.46.x as well.

johnnyshields · 2022-05-13T17:45:51Z

Ok, so fun times. It looks like this may need the same change from protobuffers. https://github.com/protocolbuffers/protobuf/blob/main/ruby/Rakefile

Will raise a PR there too.

johnnyshields · 2022-05-13T17:57:15Z

Here's the PR for protobufs: protocolbuffers/protobuf#9963

johnnyshields · 2022-05-26T10:03:22Z

@apolcyn Protobufs support has been officially released: https://github.com/protocolbuffers/protobuf/releases/tag/v21.0

I've confirmed that it installs correctly on Windows. Please kindly merge this PR.

johnnyshields · 2022-05-30T21:22:42Z

@nicolasnoble let's merge this?

apolcyn · 2022-05-31T15:32:55Z

Test failures are unrelated

* Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

johnnyshields · 2022-06-02T15:32:45Z

@lidizheng it would be great if we could get this released as 1.46.4.

lidizheng · 2022-06-02T17:13:51Z

@johnnyshields We just made a release cut for v1.47.x, cc @gnossen for deciding if we can backport or not.

* Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

…29868) * Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+ Co-authored-by: Johnny Shields <johnny.shields@gmail.com>

…) (grpc#29868) * Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

* Bump version to 1.47.0-pre1 (on v1.47.x branch) (#29830) * bump version to 1.47.0-pre1 * regenerate projects * xDS: Workaround to get gRPC clients working with istio (#29841) (#29850) * xDS: Workaround to get gRPC clients working with istio * Formatting * Comment test too * Disable instead of commenting * Support for prebuilt Ruby binary on x64-mingw-ucrt platform (#29684) (#29868) * Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+ Co-authored-by: Johnny Shields <johnny.shields@gmail.com> * use constraints value in @platforms instead of @bazel_tools//platforms bazelbuild/bazel#8622 (#30019) * Set Correct Platform Tag in Wheels on Mac OS with Python 3.10 (#29857) (#30026) * Attempt to set correct platform on Mac OS * Add some debug * Make it fail * Print more * Try again * Maybe it's an ordering issue? * Get logs back * Try copying distutils to see exactly what is being used * Actually export the variable * I just love debugging with CI * One directory higher this time * Try with an upgraded Python install * Fix version * Rebreak * Try setting it even earlier? * Unbreak * Try explicitly renaming the artifacts * Fix * I am about ready to start NAT hole punching for SSH * Break things for logs * Whoops * Clean up * Shellcheck * xds-k8s jobs: standardize TESTING_VERSION (#30027) (#30048) This Addresses the issue with skips not working in golang tests, ref b/235688697. 1. Unifies `TESTING_VERSION` detection in grpc_xds_k8s_install_test_driver.sh - new approach applicable to all languages. 2. Use `TESTING_VERSION` in all build files in `--testing_version` and when tagging docker images. This will be backported to all active test branches. Build Scripts in all other languages will be updated as well. * Bump Release Version to 1.47.0 (#30073) * bump version to 1.47.0 * regenerate projects * Using string rep for status-time (#30123) (#30145) * tell MSVC to build grpc with utf-8 (#30003) (#30153) * tell MSVC to build grpc with utf-8 fix #29979 * generate_projects Co-authored-by: AJ Heller <hork@google.com> Co-authored-by: AJ Heller <hork@google.com> Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: apolcyn <apolcyn@google.com> Co-authored-by: Johnny Shields <johnny.shields@gmail.com> Co-authored-by: Ara Nguyen <91614797+aranguyen@users.noreply.github.com> Co-authored-by: Sergii Tkachenko <sergiitk@google.com> Co-authored-by: Esun Kim <veblush@google.com> Co-authored-by: hongnod <6680267+hongnod@users.noreply.github.com> Co-authored-by: AJ Heller <hork@google.com>

johnnyshields · 2022-10-11T08:50:39Z

If 1.47.x is on the way, no need to backport. Thanks!

On Thu, Jun 2, 2022 at 10:14 Lidi Zheng ***@***.***> wrote: @johnnyshields <https://github.com/johnnyshields> We just made a release cut for v1.47.x, cc @gnossen <https://github.com/gnossen> for deciding if we can backport or not. — Reply to this email directly, view it on GitHub <#29684 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGYB62S4LBZNLN3TO7DADVNDTVVANCNFSM5V3XKRKQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Johnny Shields Co-Founder & Chief Technology Officer [image: TableCheck] <https://www.tablecheck.com/en/company/> [image: Address] Dai 27 Chuo Bldg 4F, 2-14-5 Ginza, Chuo-ku, Tokyo, Japan 104-0061 <https://goo.gl/maps/G4PyDSZE8s32> [image: Phone] +81 (0)80-3519-5647 [image: Web] ***@***.*** https://www.tablecheck.com/en/company/

Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, whic…

bb05366

…h is used for Windows RubyInstaller Ruby 3.1+

johnnyshields force-pushed the support-ruby-mingw-ucrt branch from b41014a to bb05366 Compare May 13, 2022 15:31

johnnyshields mentioned this pull request May 13, 2022

Ruby: Support prebuilt binaries for x64-mingw-ucrt platform #29666

Closed

Fix build

3b60788

johnnyshields force-pushed the support-ruby-mingw-ucrt branch from 7621663 to 3b60788 Compare May 13, 2022 16:07

nicolasnoble requested a review from apolcyn May 13, 2022 16:21

johnnyshields commented May 13, 2022

View reviewed changes

nicolasnoble added release notes: yes Indicates if PR needs to be in release notes lang/ruby kokoro:run labels May 13, 2022

grpc-kokoro removed the kokoro:run label May 13, 2022

grpc-checks bot added per-call-memory/neutral bloat/none labels May 13, 2022

nicolasnoble approved these changes May 13, 2022

View reviewed changes

apolcyn approved these changes May 13, 2022

View reviewed changes

johnnyshields mentioned this pull request May 25, 2022

Support pre-built binaries for Ruby 3.1 #29000

Merged

apolcyn merged commit 6d33399 into grpc:master May 31, 2022

dennycd pushed a commit to dennycd/grpc that referenced this pull request May 31, 2022

Support for prebuilt Ruby binary on x64-mingw-ucrt platform (grpc#29684)

e4a44f4

* Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label May 31, 2022

johnnyshields deleted the support-ruby-mingw-ucrt branch June 2, 2022 15:32

apolcyn pushed a commit to apolcyn/grpc that referenced this pull request Jun 2, 2022

Support for prebuilt Ruby binary on x64-mingw-ucrt platform (grpc#29684)

5f29600

* Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

This was referenced Jun 22, 2022

Ruby: Fixes for x64-mingw-ucrt (PR to master) #30081

Merged

Ruby: Fixes for x64-mingw-ucrt (PR to v1.47.x) #30082

Closed

Conversation

johnnyshields commented May 13, 2022

Uh oh!

linux-foundation-easycla bot commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnnyshields commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla bot commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolasnoble commented May 13, 2022

Uh oh!

johnnyshields May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolasnoble commented May 13, 2022

Uh oh!

johnnyshields commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolasnoble commented May 13, 2022

Uh oh!

johnnyshields commented May 13, 2022

Uh oh!

johnnyshields commented May 13, 2022

Uh oh!

johnnyshields commented May 13, 2022

Uh oh!

johnnyshields commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnnyshields commented May 30, 2022

Uh oh!

apolcyn commented May 31, 2022

Uh oh!

johnnyshields commented Jun 2, 2022

Uh oh!

lidizheng commented Jun 2, 2022

Uh oh!

johnnyshields commented Oct 11, 2022 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linux-foundation-easycla bot commented May 13, 2022 •

edited

Loading

johnnyshields commented May 13, 2022 •

edited

Loading

linux-foundation-easycla bot commented May 13, 2022 •

edited

Loading

johnnyshields May 13, 2022 •

edited

Loading

johnnyshields commented May 13, 2022 •

edited

Loading

johnnyshields commented May 26, 2022 •

edited

Loading