Skip to content

Ruby: Support x64-mingw-ucrt platform#9963

Merged
haberman merged 1 commit intoprotocolbuffers:mainfrom
johnnyshields:ruby-x64-mingw-ucrt-support
May 13, 2022
Merged

Ruby: Support x64-mingw-ucrt platform#9963
haberman merged 1 commit intoprotocolbuffers:mainfrom
johnnyshields:ruby-x64-mingw-ucrt-support

Conversation

@johnnyshields
Copy link
Copy Markdown
Contributor

@johnnyshields johnnyshields commented May 13, 2022 •
edited
Loading

This PR adds support for Ruby x64-mingw-ucrt platform, which is the new platform Windows Ruby Installer uses as of Ruby 3.1.

As of 3.21.0.rc.1 protobuf is not including a x64-mingw-ucrt gem package. Refer to nokogiri for the expected x64-mingw-ucrt package we should see.

Refer to this GRPC ticket for details: grpc/grpc#29666

@google-cla
Copy link
Copy Markdown

google-cla bot commented May 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@johnnyshields johnnyshields changed the title Ruby: Support x64-mingw-ucrt platform, which is the new platform whic… Ruby: Support x64-mingw-ucrt platform May 13, 2022
@johnnyshields johnnyshields force-pushed the ruby-x64-mingw-ucrt-support branch from c2fc7bd to efe526a Compare May 13, 2022 17:53
@johnnyshields
Ruby: support x64-mingw-ucrt platform, which is the new platform whic…
9254853 
…h Windows Ruby Installer uses as of Ruby 3.1
@johnnyshields johnnyshields force-pushed the ruby-x64-mingw-ucrt-support branch from efe526a to 9254853 Compare May 13, 2022 17:56
@johnnyshields johnnyshields mentioned this pull request May 13, 2022
Merged
@johnnyshields
Copy link
Copy Markdown
Contributor Author

johnnyshields commented May 13, 2022 •
edited
Loading

I've confirmed that this successfully built the Ruby gem packages in ruby/pkg dir:

image

It installs on Windows Ruby 3.1

C:\workspace\protobuf>gem install --local ruby\pkg\google-protobuf-3.20.1-x64-mingw-ucrt.gem
Successfully installed google-protobuf-3.20.1-x64-mingw-ucrt
Parsing documentation for google-protobuf-3.20.1-x64-mingw-ucrt
Installing ri documentation for google-protobuf-3.20.1-x64-mingw-ucrt
Done installing documentation for google-protobuf after 1 seconds
1 gem installed

@nicolasnoble
Copy link
Copy Markdown
Contributor

nicolasnoble commented May 13, 2022

@haberman are you still the right contact for this package?

This was referenced May 13, 2022
Merged
Closed
@fowles fowles requested a review from haberman May 13, 2022 20:12
@haberman haberman merged commit 9be7dd1 into protocolbuffers:main May 13, 2022
@haberman
Copy link
Copy Markdown
Member

haberman commented May 13, 2022

We should cherry-pick this to the release branch so that it goes out in the the 3.21.0 release.

@johnnyshields johnnyshields deleted the ruby-x64-mingw-ucrt-support branch May 14, 2022 02:39
@johnnyshields johnnyshields mentioned this pull request May 14, 2022
Merged
@johnnyshields
Copy link
Copy Markdown
Contributor Author

johnnyshields commented May 14, 2022

@haberman thanks for merging! Backport done here: #9969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haberman haberman haberman approved these changes

Assignees

No one assigned

Labels

ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@johnnyshields @nicolasnoble @haberman @fowles @protobuf-kokoro