Skip to content

xds-k8s jobs: standardize TESTING_VERSION (1.47.x backport)#30048

Merged
sergiitk merged 1 commit intogrpc:v1.47.xfrom
sergiitk:backport-xds-k8s-testing-version-1.47
Jun 17, 2022
Merged

xds-k8s jobs: standardize TESTING_VERSION (1.47.x backport)#30048
sergiitk merged 1 commit intogrpc:v1.47.xfrom
sergiitk:backport-xds-k8s-testing-version-1.47

Conversation

@sergiitk
Copy link
Copy Markdown
Member

This Addresses the issue with skips not working in golang tests, ref b/235688697.

  1. Unifies TESTING_VERSION detection in grpc_xds_k8s_install_test_driver.sh - new approach applicable to all languages.
  2. Use TESTING_VERSION in all build files in --testing_version and when tagging docker images. This will be backported to all active test branches. Build Scripts in all other languages will be updated as well.

Backport of #30027

This Addresses the issue with skips not working in golang tests, ref b/235688697. 

1. Unifies `TESTING_VERSION` detection  in grpc_xds_k8s_install_test_driver.sh - new approach applicable to all languages.
2. Use `TESTING_VERSION` in all build files in `--testing_version` and when tagging docker images. This will be backported to all active test branches. Build Scripts in all other languages will be updated as well.
@sergiitk sergiitk requested a review from gnossen June 17, 2022 21:45
@sergiitk sergiitk added the release notes: no Indicates if PR should not be in release notes label Jun 17, 2022
@sergiitk sergiitk merged commit cb2fedf into grpc:v1.47.x Jun 17, 2022
@sergiitk sergiitk deleted the backport-xds-k8s-testing-version-1.47 branch June 17, 2022 22:21
yashykt added a commit that referenced this pull request Jul 1, 2022
* Bump version to 1.47.0-pre1 (on v1.47.x branch) (#29830)

* bump version to 1.47.0-pre1

* regenerate projects

* xDS: Workaround to get gRPC clients working with istio (#29841) (#29850)

* xDS: Workaround to get gRPC clients working with istio

* Formatting

* Comment test too

* Disable instead of commenting

* Support for prebuilt Ruby binary on x64-mingw-ucrt platform (#29684) (#29868)

* Add support for prebuilt Ruby binary on x64-mingw-ucrt platform, which is used for Windows RubyInstaller Ruby 3.1+

Co-authored-by: Johnny Shields <johnny.shields@gmail.com>

* use constraints value in @platforms instead of @bazel_tools//platforms bazelbuild/bazel#8622 (#30019)

* Set Correct Platform Tag in Wheels on Mac OS with Python 3.10 (#29857) (#30026)

* Attempt to set correct platform on Mac OS

* Add some debug

* Make it fail

* Print more

* Try again

* Maybe it's an ordering issue?

* Get logs back

* Try copying distutils to see exactly what is being used

* Actually export the variable

* I just love debugging with CI

* One directory higher this time

* Try with an upgraded Python install

* Fix version

* Rebreak

* Try setting it even earlier?

* Unbreak

* Try explicitly renaming the artifacts

* Fix

* I am about ready to start NAT hole punching for SSH

* Break things for logs

* Whoops

* Clean up

* Shellcheck

* xds-k8s jobs: standardize TESTING_VERSION (#30027) (#30048)

This Addresses the issue with skips not working in golang tests, ref b/235688697. 

1. Unifies `TESTING_VERSION` detection  in grpc_xds_k8s_install_test_driver.sh - new approach applicable to all languages.
2. Use `TESTING_VERSION` in all build files in `--testing_version` and when tagging docker images. This will be backported to all active test branches. Build Scripts in all other languages will be updated as well.

* Bump Release Version to 1.47.0 (#30073)

* bump version to 1.47.0

* regenerate projects

* Using string rep for status-time (#30123) (#30145)

* tell MSVC to build grpc with utf-8 (#30003) (#30153)

* tell MSVC to build grpc with utf-8

fix #29979

* generate_projects

Co-authored-by: AJ Heller <hork@google.com>

Co-authored-by: AJ Heller <hork@google.com>

Co-authored-by: Richard Belleville <rbellevi@google.com>
Co-authored-by: apolcyn <apolcyn@google.com>
Co-authored-by: Johnny Shields <johnny.shields@gmail.com>
Co-authored-by: Ara Nguyen <91614797+aranguyen@users.noreply.github.com>
Co-authored-by: Sergii Tkachenko <sergiitk@google.com>
Co-authored-by: Esun Kim <veblush@google.com>
Co-authored-by: hongnod <6680267+hongnod@users.noreply.github.com>
Co-authored-by: AJ Heller <hork@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/none per-call-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants