feat: optimize docker test by hwbrzzl · Pull Request #612 · goravel/framework

hwbrzzl · 2024-08-23T16:19:35Z

📑 Description

Implement basic facades.Schema logic, I found the docker test needs to be optimized when implementing facades.Schema, and it only contains a few codes, so I add them into this PR directly.
Optimize the docker test experience, reduce the Linux test from ~7m to ~3m. Currently, we can use supportdocker.Mysql() to get a Mysql Docker instance directly, and the instance will be cached, every test case that uses the docker instance can get the singleton instance.

✅ Checks

Added test cases for my code

coderabbitai · 2024-08-23T16:19:42Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Tip

Early access features: enabled

We are currently testing the following features in early access:

Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
Please join our Discord Community to provide feedback and report issues on the discussion post.

codecov · 2024-09-01T15:45:20Z

Codecov Report

Attention: Patch coverage is 62.18487% with 45 lines in your changes missing coverage. Please review.

Project coverage is 69.93%. Comparing base (f2f6637) to head (d8a3f27).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
support/docker/docker.go	41.50%	27 Missing and 4 partials ⚠️
database/migration/schema.go	0.00%	10 Missing ⚠️
database/service_provider.go	0.00%	2 Missing ⚠️
foundation/container.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   69.96%   69.93%   -0.04%     
==========================================
  Files         184      184              
  Lines       11252    11260       +8     
==========================================
+ Hits         7873     7875       +2     
- Misses       2800     2815      +15     
+ Partials      579      570       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devhaozi

LGTM

* feat: install all facades * optimize * feat: optimize install all facades * add tests * Update foundation/console/package_install_command.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Bowen <bowen@BowendeMacBook-Pro.local> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat: [#612] Optimize install Testing * Update testing/setup/stubs.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* feat: [#612] Optimize install DB * add tests * optimize

* feat: [#612] Optimize install missing * optimize * fix tests

* feat: [#612] Optimize install Database * optimize --------- Co-authored-by: Bowen <hwbrzzl@github.com>

optimize test

27b6d0d

hwbrzzl mentioned this pull request Aug 26, 2024

feat: add WhereHas method #602

Closed

1 task

hwbrzzl and others added 7 commits August 26, 2024 22:04

Fix test cases

6b8d8bb

chore: update mocks

95e2898

fix test cases

dbba9db

fix test cases

a6b846e

fix test cases

0bfeb17

optimize test

ebd0f72

optimize test

062af8b

hwbrzzl marked this pull request as ready for review September 2, 2024 09:42

hwbrzzl requested a review from a team as a code owner September 2, 2024 09:42

hwbrzzl added 3 commits September 2, 2024 17:42

Merge branch 'master' into bowen/#280-2

4834224

optimize test cases

f0da731

remove sqlite DB files

d8a3f27

devhaozi approved these changes Sep 3, 2024

View reviewed changes

hwbrzzl merged commit ef2c2cb into master Sep 3, 2024

hwbrzzl deleted the bowen/#280-2 branch September 3, 2024 00:58

hwbrzzl added a commit that referenced this pull request Oct 1, 2025

feat: [#612] Optimize install Testing

ecae39a

hwbrzzl added a commit that referenced this pull request Oct 1, 2025

feat: [#612] Optimize install DB

84c0582

hwbrzzl added a commit that referenced this pull request Oct 3, 2025

feat: [#612] Optimize install DB (#1214)

179304d

* feat: [#612] Optimize install DB * add tests * optimize

hwbrzzl added a commit that referenced this pull request Oct 3, 2025

feat: [#612] Optimize install missing

b121b94

hwbrzzl added a commit that referenced this pull request Oct 3, 2025

feat: [#612] Optimize install missing (#1216)

5eab81f

* feat: [#612] Optimize install missing * optimize * fix tests

hwbrzzl added a commit that referenced this pull request Oct 3, 2025

feat: [#612] Optimize install Database

78c7309

hwbrzzl added a commit that referenced this pull request Oct 4, 2025

feat: [#612] Optimize install Database (#1218)

614ddd1

* feat: [#612] Optimize install Database * optimize --------- Co-authored-by: Bowen <hwbrzzl@github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: optimize docker test#612

feat: optimize docker test#612
hwbrzzl merged 11 commits intomasterfrom
bowen/#280-2

hwbrzzl commented Aug 23, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 23, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Sep 1, 2024 •

edited

Loading

Uh oh!

devhaozi left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

hwbrzzl commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📑 Description

✅ Checks

Uh oh!

coderabbitai bot commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Sep 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

devhaozi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hwbrzzl commented Aug 23, 2024 •

edited

Loading

coderabbitai bot commented Aug 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Sep 1, 2024 •

edited

Loading