Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the install process for missing packages by restructuring the setup code for queue and event packages, and fixing console command kernel initialization. The changes improve the organization and reliability of package installation by using variables for repeated strings and handling existing files more gracefully.
- Refactored queue and event setup files to use variables for commonly repeated strings and reorganized installation/uninstallation logic
- Fixed console command kernel initialization to always modify the AppServiceProvider regardless of kernel file existence
- Updated test cases to reflect the new behavior of kernel initialization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| queue/setup/setup.go | Extracted string literals into variables and reorganized install/uninstall operations with better comments |
| event/setup/setup.go | Applied similar refactoring as queue setup with variable extraction and improved organization |
| console/console/make_command_test.go | Updated test cases to match new kernel initialization behavior |
| console/console/make_command.go | Fixed kernel initialization logic to always modify AppServiceProvider and added missing return statement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
- Coverage 66.82% 66.57% -0.25%
==========================================
Files 237 237
Lines 15784 15845 +61
==========================================
+ Hits 10547 10549 +2
- Misses 4871 4930 +59
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📑 Description
Relate goravel/goravel#612
facades.Artisan().Registeris not added in some cases.facades.Event().Registerwhen installing Event.facades.Queue().Registerwhen installing Queue.✅ Checks