feat: [#612] Optimize install Database#1218
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1218 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 237 237
Lines 15845 15845
=======================================
Hits 10549 10549
Misses 4930 4930
Partials 366 366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the database installation process by simplifying the default configuration and adding explicit database driver specifications. The changes aim to improve the database setup flow by removing environment variable dependencies during initial installation and providing clear driver options.
- Removed environment variable dependency for default database connection during setup
- Added explicit database driver specifications for both Database and Queue bindings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| database/setup/stubs.go | Simplified default database connection to empty string instead of environment variable |
| contracts/binding/binding.go | Added explicit database driver arrays for Database and Queue binding configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📑 Description
Relate goravel/goravel#612
✅ Checks