feat(spring): use shared configuration #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5de117 to
f1d5577
Compare
Contributor
Author
|
Force pushed a rebase on |
f1d5577 to
2f092e5
Compare
Contributor
Author
|
Another force push to match current changes of |
2f092e5 to
1b68fc3
Compare
1b68fc3 to
0b6d3bb
Compare
zhumin8
approved these changes
Nov 15, 2022
src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/api/generator/spring/utils/GlobalPropertiesUtils.java
Show resolved
Hide resolved
diegomarquezp
commented
Nov 21, 2022
src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
Show resolved
Hide resolved
emmileaf
reviewed
Nov 22, 2022
Contributor
emmileaf
left a comment
There was a problem hiding this comment.
Left comments on one of the golden files so it's easier to read, but please resolve in corresponding composer/util methods - thanks!
...java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfigurationFull.golden
Outdated
Show resolved
Hide resolved
...java/com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfigurationFull.golden
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
emmileaf
approved these changes
Nov 23, 2022
zhumin8
added a commit
that referenced
this pull request
Dec 16, 2022
…1123) As discussed off-line, instead of depending on a new `global-properties` module, use `CredentialsProvider` bean from `spring-cloud-gcp-autoconfigure` instead. - Replace dependency from `core` to `autoconfigure` module. - Revert #1071 and implement changes shown in [poc](zhumin8/language_poc1#7) - Minor code cleanups and util method extracted from `SpringPropertiesClassComposer.java`. Note: #1071 and GoogleCloudPlatform/spring-cloud-gcp#1308 will be obsolete after this change. Also, conflicts needs to be resolved between this pr and #1110 depending on merging order.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification of generated autoconfig to use shared properties, as demonstrated here
It will have changes coming from
autoconfig-gen-draft2-array-annotation(should be reviewed first) since it depends on anonymous arrays for annotations.The main changes are in the autoconfig composer and updated golden files.