Skip to content

fix(spring codegen): use client-library-artifact-id as pom artifactId prefix #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhumin8 merged 1 commit into from
Nov 14, 2022
Merged

fix(spring codegen): use client-library-artifact-id as pom artifactId prefix #1092

zhumin8 merged 1 commit into from
Nov 14, 2022

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Nov 11, 2022 •
edited
Loading

Instead of package name, use corresponding client library's artifact-id as artifact id prefix for spring modules.
Reasoning of this change:

  • Generated module artifact name aligned better with corresponding client library's, less confusing for users.
  • "client-library-artifact-id" is already needed to substitute in generation script, so no added item there.
  • Charging from monorepo, only one version of client library is published per module. So consider the generation process starts from a client library coordinates, then the risk of not including -v1beta1/-v1 from package name is mininum.
  • It's more direct this way to generate README item in spring-cloud-gcp side. codegen: adding documentation items for generated modules GoogleCloudPlatform/spring-cloud-gcp#1336

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Nov 11, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhumin8 zhumin8 mentioned this pull request Nov 11, 2022
Merged
@zhumin8 zhumin8 marked this pull request as ready for review November 11, 2022 20:21
@zhumin8 zhumin8 requested a review from a team November 11, 2022 20:21
@zhumin8 zhumin8 requested a review from a team as a code owner November 11, 2022 20:21
@zhumin8 zhumin8 merged commit c79dab2 into autoconfig-gen-draft2 Nov 14, 2022
@zhumin8 zhumin8 deleted the pom-fix branch November 14, 2022 15:15
diegomarquezp pushed a commit that referenced this pull request Nov 14, 2022
@zhumin8 @diegomarquezp
fix(spring codegen): use client-library-artifact-id as pom artifactId…
2532e78 
… prefix. (#1092)
diegomarquezp added a commit that referenced this pull request Nov 24, 2022
@diegomarquezp @zhumin8
feat(spring): use shared configuration (#1071)
8755403 
* fix(spring codegen): use client-library-artifact-id as pom artifactId prefix. (#1092)

* rename to global properties

* fix(test): update goldens

* fix: format

* fix: typo in GLobalProperties

* fix: typo in goldens

* fix: remove unnecessary comments

* fix: reference to com.google.cloud.spring.global

* fix: typo and static ref fix

Co-authored-by: Min Zhu <zhumin@google.com>
@zhumin8 zhumin8 added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@elefeint elefeint Awaiting requested review from elefeint

+1 more reviewer

@emmileaf emmileaf emmileaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhumin8 @emmileaf @diegomarquezp