feat(ast): array expressions #1070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
222e841 to
6974740
Compare
Contributor
Author
|
Force pushed an alternate approach using |
609a6fc to
016dc32
Compare
fdb794b to
e2d08c4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
Can you delete this PR and open another PR against main branch? As this would be a good feature added to the generator itself |
Contributor
Author
|
Closing by request |
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
* deps: update dependency com.google.api:gax-bom to v2.21.0 * deps: Updating proto-google-common-protos to 2.12.0 Co-authored-by: Deepankar Dixit <90280028+ddixit14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ArrayExprto allow anonymous arrays (e.g.{"value1", "value2"}). Same type validation is enforced (e.g.{"string1", 1.2f}is not allowed).AnnotationNodenow allows anArrayExpras a single description. For multiple descriptions, a wrappingAssignmentExpris still needed.This PR is to help generate annotations with an anonymous array like this
@EnableConfigurationProperties({LanguageProperties.class, SharedProperties.class})It also enables assignments to arrays in the form
String[] arr = {"str1", "str2"}- botharrand the anon array should be of typeTypeNode.arrayOf(TypeNode.STRING)for this example (arrayOf()was also introduced in this PR)