Skip to content

feat(spanner): PGNumeric implements Scanner and Valuer#13722

Merged
olavloite merged 2 commits intomainfrom
spanner-pgnumeric-scan
Jan 27, 2026
Merged

feat(spanner): PGNumeric implements Scanner and Valuer#13722
olavloite merged 2 commits intomainfrom
spanner-pgnumeric-scan

Conversation

@olavloite
Copy link
Copy Markdown
Contributor

@olavloite olavloite commented Jan 23, 2026

Implement the Scanner and Valuer interfaces for PGNumeric so this type is easier to use with the database/sql driver.

@olavloite
feat(spanner): PGNumeric implements Scanner and Valuer
78dcc01 
Implement the Scanner and Valuer interfaces for PGNumeric so this type is
easier to use with the database/sql driver.
@olavloite olavloite requested review from a team January 23, 2026 16:54
@olavloite olavloite requested a review from a team as a code owner January 23, 2026 16:54
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 23, 2026
@olavloite olavloite requested a review from rahul2393 January 23, 2026 16:54
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 23, 2026

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the interoperability of the PGNumeric type within the Spanner client library by conforming it to Go's standard database/sql driver interfaces. This change allows developers to more easily use PGNumeric when interacting with SQL databases, streamlining data handling and reducing the need for manual type conversions.

Highlights

  • PGNumeric Type Enhancement: The PGNumeric type now implements the database/sql Scanner and Valuer interfaces, enabling seamless integration with standard Go SQL operations.
  • Flexible Scanning: The Scan method for PGNumeric has been implemented to handle a wide range of input types, including string, float32, float64, big.Rat, NullNumeric, and their pointer equivalents, as well as nil values.
  • Comprehensive Testing: New test cases have been added to spanner/value_test.go to ensure the robustness and correctness of the PGNumeric.Scan method across various data types and scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the driver.Valuer and sql.Scanner interfaces for the PGNumeric type, which is a great addition for database/sql compatibility. The implementation is mostly solid, but I've found a correctness issue in the Scan method when handling null NullNumeric values, which could lead to an inconsistent state in the PGNumeric struct. Additionally, I've identified a couple of areas for improvement in the tests to make them more robust and to fix a minor bug in a test helper. My review comments include specific suggestions to address these points.

rahul2393
rahul2393 previously approved these changes Jan 26, 2026
View reviewed changes
@olavloite olavloite requested a review from rahul2393 January 26, 2026 17:08
@olavloite olavloite merged commit 85bc9db into main Jan 27, 2026
10 checks passed
@olavloite olavloite deleted the spanner-pgnumeric-scan branch January 27, 2026 06:39
krishnamd-jkp pushed a commit that referenced this pull request Jan 28, 2026
@olavloite @krishnamd-jkp
feat(spanner): PGNumeric implements Scanner and Valuer (#13722)
161d24c 
Implement the Scanner and Valuer interfaces for PGNumeric so this type
is easier to use with the database/sql driver.
@rahul2393 rahul2393 mentioned this pull request Feb 11, 2026
Merged
rahul2393 added a commit that referenced this pull request Feb 11, 2026
@rahul2393
chore: librarian release pull request: 20260211T232929Z (#13835)
80561cb 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29
<details><summary>spanner: 1.88.0</summary>

##
[1.88.0](spanner/v1.87.0...spanner/v1.88.0)
(2026-02-11)

### Features

* Adding Send and Ack Mutation Support for Cloud Spanner Queue (#13616)
([1cf600d](1cf600d6))

* include cache updates into the ResultSet response (PiperOrigin-RevId:
865546011)
([6f31019](6f310199))

* add a ClientContext field to Spanner requests (PiperOrigin-RevId:
853323071)
([80379ed](80379edb))

* add Secure Parameters to the ClientContext (PiperOrigin-RevId:
853323071)
([80379ed](80379edb))

* PGNumeric implements Scanner and Valuer (#13722)
([85bc9db](85bc9dbf))

* support struct literal (#13766)
([b4a6f4c](b4a6f4c5))

* Exposing total CPU related fields in AutoscalingConfig
(PiperOrigin-RevId: 845819318)
([db65e79](db65e792))

* add ClientContext support (#13775)
([e85d706](e85d7061))

### Bug Fixes

* disable config logging by default (#13478)
([ad19592](ad19592e))

* decode PG JSONB array to PGJsonB struct (#13602)
([d72d0f4](d72d0f45))

### Performance Improvements

* only create sessions if multiplexed sessions are disabled (#13477)
([e44e58f](e44e58f6))

### Documentation

* A comment for field `param_types` in message
`.google.spanner.v1.PartitionQueryRequest` is changed
(PiperOrigin-RevId: 865546011)
([6f31019](6f310199))

* A comment for field `transaction_tag` in message
`.google.spanner.v1.RequestOptions` is changed (PiperOrigin-RevId:
865546011)
([6f31019](6f310199))

* A comment for field `commit_timestamp` in message
`.google.spanner.v1.BatchWriteResponse` is changed (PiperOrigin-RevId:
865546011)
([6f31019](6f310199))

* A comment for field `params` in message
`.google.spanner.v1.PartitionQueryRequest` is changed
(PiperOrigin-RevId: 865546011)
([6f31019](6f310199))

* Update client side metrics and permission issues in README (#13491)
([ab56892](ab56892e))

* Update high_priority_cpu_utilization_percent in AutoscalingConfig to
be Optional and clarify its behavior when not specified
(PiperOrigin-RevId: 845819318)
([db65e79](db65e792))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olavloite @rahul2393