Skip to content

fix(spanner): decode PG JSONB array to PGJsonB struct#13602

Merged
olavloite merged 1 commit intomainfrom
spanner-decode-jsonb-array
Jan 14, 2026
Merged

fix(spanner): decode PG JSONB array to PGJsonB struct#13602
olavloite merged 1 commit intomainfrom
spanner-decode-jsonb-array

Conversation

@olavloite
Copy link
Copy Markdown
Contributor

@olavloite olavloite commented Jan 14, 2026

Decoding arrays of PostgreSQL JSONB values into a slice of PGJsonB structs failed due to a faulty check of the array element type code annotation.

@olavloite olavloite requested review from a team January 14, 2026 13:44
@olavloite olavloite requested a review from a team as a code owner January 14, 2026 13:44
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 14, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 14, 2026

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the Spanner client's PostgreSQL JSONB decoding logic. The issue prevented the correct interpretation of arrays containing PGJsonB values, stemming from a subtle error in how array element type annotations were referenced. The change ensures that PGJsonB arrays are now correctly decoded, improving the robustness and reliability of PostgreSQL JSONB support within the Spanner client.

Highlights

  • Bug Fix for PG JSONB Array Decoding: Corrected an issue where decoding arrays of PostgreSQL JSONB values into PGJsonB structs failed due to an incorrect variable name in a type annotation check.
  • Variable Name Correction: The typeAnnotation variable was replaced with atypeAnnotation in the decodeValue function to ensure the correct array element type annotation is checked.
  • Expanded Test Coverage: New test cases have been added to spanner/value_test.go to validate the decoding of individual PGJsonB values and arrays of PGJsonB values, including edge cases like nulls and invalid JSON.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug preventing the decoding of ARRAY<PG_JSONB> into a []PGJsonB slice. The change in spanner/value.go properly uses the array element's type annotation for the check. The accompanying tests in spanner/value_test.go are thorough and cover the fix well. I have one suggestion to enhance the test coverage by adding a case for an empty array.

@olavloite olavloite requested a review from rahul2393 January 14, 2026 14:14
@olavloite
fix(spanner): decode PG JSONB array to PGJsonB struct
7c0f9b6 
Decoding arrays of PostgreSQL JSONB values into a slice of PGJsonB structs failed
due to a faulty check of the array element type code annotation.
@olavloite olavloite force-pushed the spanner-decode-jsonb-array branch from 429cb80 to 7c0f9b6 Compare January 14, 2026 14:16
@olavloite olavloite merged commit d72d0f4 into main Jan 14, 2026
10 checks passed
@olavloite olavloite deleted the spanner-decode-jsonb-array branch January 14, 2026 14:49
krishnamd-jkp pushed a commit that referenced this pull request Jan 28, 2026
@olavloite @krishnamd-jkp
fix(spanner): decode PG JSONB array to PGJsonB struct (#13602)
c417811 
Decoding arrays of PostgreSQL JSONB values into a slice of PGJsonB
structs failed due to a faulty check of the array element type code
annotation.
@rahul2393 rahul2393 mentioned this pull request Feb 11, 2026
Merged
rahul2393 added a commit that referenced this pull request Feb 11, 2026
@rahul2393
chore: librarian release pull request: 20260211T232929Z (#13835)
80561cb 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29
<details><summary>spanner: 1.88.0</summary>

##
[1.88.0](spanner/v1.87.0...spanner/v1.88.0)
(2026-02-11)

### Features

* Adding Send and Ack Mutation Support for Cloud Spanner Queue (#13616)
([1cf600d](1cf600d6))

* include cache updates into the ResultSet response (PiperOrigin-RevId:
865546011)
([6f31019](6f310199))

* add a ClientContext field to Spanner requests (PiperOrigin-RevId:
853323071)
([80379ed](80379edb))

* add Secure Parameters to the ClientContext (PiperOrigin-RevId:
853323071)
([80379ed](80379edb))

* PGNumeric implements Scanner and Valuer (#13722)
([85bc9db](85bc9dbf))

* support struct literal (#13766)
([b4a6f4c](b4a6f4c5))

* Exposing total CPU related fields in AutoscalingConfig
(PiperOrigin-RevId: 845819318)
([db65e79](db65e792))

* add ClientContext support (#13775)
([e85d706](e85d7061))

### Bug Fixes

* disable config logging by default (#13478)
([ad19592](ad19592e))

* decode PG JSONB array to PGJsonB struct (#13602)
([d72d0f4](d72d0f45))

### Performance Improvements

* only create sessions if multiplexed sessions are disabled (#13477)
([e44e58f](e44e58f6))

### Documentation

* A comment for field `param_types` in message
`.google.spanner.v1.PartitionQueryRequest` is changed
(PiperOrigin-RevId: 865546011)
([6f31019](6f310199))

* A comment for field `transaction_tag` in message
`.google.spanner.v1.RequestOptions` is changed (PiperOrigin-RevId:
865546011)
([6f31019](6f310199))

* A comment for field `commit_timestamp` in message
`.google.spanner.v1.BatchWriteResponse` is changed (PiperOrigin-RevId:
865546011)
([6f31019](6f310199))

* A comment for field `params` in message
`.google.spanner.v1.PartitionQueryRequest` is changed
(PiperOrigin-RevId: 865546011)
([6f31019](6f310199))

* Update client side metrics and permission issues in README (#13491)
([ab56892](ab56892e))

* Update high_priority_cpu_utilization_percent in AutoscalingConfig to
be Optional and clarify its behavior when not specified
(PiperOrigin-RevId: 845819318)
([db65e79](db65e792))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olavloite @rahul2393