fix(spanner): disable config logging by default#13478
Conversation
Disables the config logging at startup by default. Config logging can be enabled by setting either of the environment variables GOOGLE_CLOUD_SPANNER_ENABLE_LOG_CLIENT_OPTIONS or GOOGLE_CLOUD_SPANNER_DISABLE_LOG_CLIENT_OPTIONS. If neither of these variables have been set, logging will be disabled.
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the Spanner client library to disable configuration logging by default during application startup. The primary goal is to reduce excessive log output by ensuring that client configuration details are only logged when explicitly enabled through specific environment variables, rather than being logged automatically. This improves the clarity and signal-to-noise ratio of application logs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request changes the default behavior of client configuration logging to be disabled, which is a sensible default to avoid excessive logging. It introduces a new environment variable to explicitly enable logging, while maintaining the old variable for disabling it for backward compatibility. The logic is sound. I've added one suggestion to refactor the implementation to reduce code duplication by using a local helper function, which should improve maintainability.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:19bb93e8f1f916c61b597db2bad65dc432f79baaabb210499d7d0e4ad1dffe29 <details><summary>spanner: 1.88.0</summary> ## [1.88.0](spanner/v1.87.0...spanner/v1.88.0) (2026-02-11) ### Features * Adding Send and Ack Mutation Support for Cloud Spanner Queue (#13616) ([1cf600d](1cf600d6)) * include cache updates into the ResultSet response (PiperOrigin-RevId: 865546011) ([6f31019](6f310199)) * add a ClientContext field to Spanner requests (PiperOrigin-RevId: 853323071) ([80379ed](80379edb)) * add Secure Parameters to the ClientContext (PiperOrigin-RevId: 853323071) ([80379ed](80379edb)) * PGNumeric implements Scanner and Valuer (#13722) ([85bc9db](85bc9dbf)) * support struct literal (#13766) ([b4a6f4c](b4a6f4c5)) * Exposing total CPU related fields in AutoscalingConfig (PiperOrigin-RevId: 845819318) ([db65e79](db65e792)) * add ClientContext support (#13775) ([e85d706](e85d7061)) ### Bug Fixes * disable config logging by default (#13478) ([ad19592](ad19592e)) * decode PG JSONB array to PGJsonB struct (#13602) ([d72d0f4](d72d0f45)) ### Performance Improvements * only create sessions if multiplexed sessions are disabled (#13477) ([e44e58f](e44e58f6)) ### Documentation * A comment for field `param_types` in message `.google.spanner.v1.PartitionQueryRequest` is changed (PiperOrigin-RevId: 865546011) ([6f31019](6f310199)) * A comment for field `transaction_tag` in message `.google.spanner.v1.RequestOptions` is changed (PiperOrigin-RevId: 865546011) ([6f31019](6f310199)) * A comment for field `commit_timestamp` in message `.google.spanner.v1.BatchWriteResponse` is changed (PiperOrigin-RevId: 865546011) ([6f31019](6f310199)) * A comment for field `params` in message `.google.spanner.v1.PartitionQueryRequest` is changed (PiperOrigin-RevId: 865546011) ([6f31019](6f310199)) * Update client side metrics and permission issues in README (#13491) ([ab56892](ab56892e)) * Update high_priority_cpu_utilization_percent in AutoscalingConfig to be Optional and clarify its behavior when not specified (PiperOrigin-RevId: 845819318) ([db65e79](db65e792)) </details>
Disables the config logging at startup by default. Config logging can be enabled by setting either of the environment variables
GOOGLE_CLOUD_SPANNER_ENABLE_LOG_CLIENT_OPTIONSorGOOGLE_CLOUD_SPANNER_DISABLE_LOG_CLIENT_OPTIONS. If neither of these variables have been set, logging will be disabled.