This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: upgrade proto-loader and add long dev dependency#1253
Merged
summer-ji-eng merged 2 commits intomainfrom May 5, 2022
Merged
fix: upgrade proto-loader and add long dev dependency#1253summer-ji-eng merged 2 commits intomainfrom
summer-ji-eng merged 2 commits intomainfrom
Conversation
This was referenced May 5, 2022
| "typescript": "^3.8.3", | ||
| "walkdir": "^0.4.0", | ||
| "webpack": "^4.34.0", | ||
| "webpack": "^5.0.0", |
Contributor
There was a problem hiding this comment.
This sneaked in - I don't think it's related to this PR?
Contributor
Author
There was a problem hiding this comment.
Right, I got dependency tree error because karmar-webpack ask for 5.0.0. Without this update, it cause fails on npm install.
alexander-fenster
approved these changes
May 5, 2022
Contributor
alexander-fenster
left a comment
There was a problem hiding this comment.
Let's merge it but not release in 2.x, otherwise we'll get a wave of PRs changing client libraries. It will be good if we can do it within the big change (drop Node 10, start using gax 3.x).
This was referenced May 5, 2022
4 tasks
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 3, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/gax-nodejs/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕 #1253 only did it for some files, not all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gax dependency
grpc/proto-loaderswitch long dependency back to 4.x grpc/grpc-node#2114It address googleapis/google-cloud-node-core#317