proto-loader: Switch long dependency back to 4.x#2114
Merged
murgatroid99 merged 1 commit intogrpc:masterfrom May 5, 2022
Merged
proto-loader: Switch long dependency back to 4.x#2114murgatroid99 merged 1 commit intogrpc:masterfrom
long dependency back to 4.x#2114murgatroid99 merged 1 commit intogrpc:masterfrom
Conversation
nicolasnoble
approved these changes
May 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts it back to the way it was before I started changing this, but leaves the change to the
importline intact so that it is still compatible with 5.x. When I started this, I didn't realize thatlong4.x actually has a separate@types/longpackage, but 5.x includes its types. TypeScript seems to prefer the included type information, so the types in 5.x would override the types for 4.x even if the user explicitly declared a dependency on@types/long4.x.This should fix #2113.