Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: include Long import in d.ts files#1379

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
SimenB:patch-1
Feb 3, 2023
Merged

fix: include Long import in d.ts files#1379
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
SimenB:patch-1

Conversation

@SimenB
Copy link
Contributor

@SimenB SimenB commented Nov 11, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

#1253 only did it for some files, not all.

@SimenB SimenB requested a review from a team as a code owner November 11, 2022 13:19
@SimenB SimenB requested a review from a team November 11, 2022 13:19
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 11, 2022
@SimenB
Copy link
Contributor Author

SimenB commented Jan 27, 2023

@alexander-fenster could you take a look?

@alexander-fenster alexander-fenster added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Feb 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 3, 2023
@alexander-fenster
Copy link
Contributor

Thanks @SimenB, I'm going to merge it now and release.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 3, 2023
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 3, 2023
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Feb 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8d9d684 into googleapis:main Feb 3, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 3, 2023
@SimenB SimenB deleted the patch-1 branch February 3, 2023 08:20
@SimenB
Copy link
Contributor Author

SimenB commented Feb 3, 2023

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants