This repository was archived by the owner on Nov 18, 2025. It is now read-only.
fix: isolate Rest Stream from retry logic to avoid backpressure#1226
Merged
summer-ji-eng merged 3 commits intomainfrom Apr 28, 2022
Merged
fix: isolate Rest Stream from retry logic to avoid backpressure#1226summer-ji-eng merged 3 commits intomainfrom
summer-ji-eng merged 3 commits intomainfrom
Conversation
This was referenced Apr 23, 2022
Merged
alexander-fenster
approved these changes
Apr 28, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 3, 2022
🤖 I have created a release *beep* *boop* --- ### [2.30.3](v2.30.2...v2.30.3) (2022-05-03) ### Bug Fixes * handle stream callback is undefined ([#1238](#1238)) ([269f805](269f805)) * isolate Rest Stream from retry logic to avoid backpressure ([#1226](#1226)) ([485d5b2](485d5b2)) * pin @grpc/proto-loader to v0.6.9 ([#1242](#1242)) ([bca9a91](bca9a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
summer-ji-eng
added a commit
that referenced
this pull request
May 6, 2022
summer-ji-eng
added a commit
that referenced
this pull request
May 9, 2022
summer-ji-eng
added a commit
that referenced
this pull request
May 9, 2022
miguelvelezsa
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Jul 23, 2025
🤖 I have created a release *beep* *boop* --- ### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03) ### Bug Fixes * handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805)) * isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2)) * pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa
pushed a commit
to googleapis/google-cloud-node-core
that referenced
this pull request
Oct 22, 2025
🤖 I have created a release *beep* *boop* --- ### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03) ### Bug Fixes * handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805)) * isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2)) * pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda
pushed a commit
to googleapis/google-cloud-node-core
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03) ### Bug Fixes * handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805)) * isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2)) * pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda
pushed a commit
to googleapis/google-cloud-node-core
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03) ### Bug Fixes * handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805)) * isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2)) * pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of
retry-requestfor rest server-stream.retry-requestcause problem:gax returns the
StreamProxythat a customer can read the data. This proxy stream setsRetryStream(A wrapper ofStreamArrayPaserwith retry logic) asReadableStream. In the retry-request implementation, the stream listens on a response event where it is not the event that would be emitted by HTTP response.body or StreamArrayPaser. It somehow causes a miss forward data event when pipe to the next stream. That’s also the reason we need to forward data, end, error events in stream.ts before.Reason to remove
retry-request: