Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: handle rest stream callback is undefined#1238

Merged
alexander-fenster merged 1 commit intomainfrom
callback_strean
May 3, 2022
Merged

fix: handle rest stream callback is undefined#1238
alexander-fenster merged 1 commit intomainfrom
callback_strean

Conversation

@summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Apr 29, 2022

HTTP response with error, streamArrayPaser should emit 'error' event.

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner April 29, 2022 19:10
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 29, 2022
@summer-ji-eng summer-ji-eng changed the title fix: handle stream callback is undefined fix: handle rest stream callback is undefined Apr 29, 2022
@summer-ji-eng summer-ji-eng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2022
@summer-ji-eng summer-ji-eng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2022
@alexander-fenster alexander-fenster merged commit 269f805 into main May 3, 2022
@alexander-fenster alexander-fenster deleted the callback_strean branch May 3, 2022 17:03
gcf-merge-on-green bot pushed a commit that referenced this pull request May 3, 2022
🤖 I have created a release *beep* *boop*
---


### [2.30.3](v2.30.2...v2.30.3) (2022-05-03)


### Bug Fixes

* handle stream callback is undefined ([#1238](#1238)) ([269f805](269f805))
* isolate Rest Stream from retry logic to avoid backpressure ([#1226](#1226)) ([485d5b2](485d5b2))
* pin @grpc/proto-loader to v0.6.9 ([#1242](#1242)) ([bca9a91](bca9a91))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa pushed a commit to googleapis/google-cloud-node that referenced this pull request Jul 23, 2025
🤖 I have created a release *beep* *boop*
---


### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03)


### Bug Fixes

* handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805))
* isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2))
* pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa pushed a commit to googleapis/google-cloud-node-core that referenced this pull request Oct 22, 2025
🤖 I have created a release *beep* *boop*
---


### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03)


### Bug Fixes

* handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805))
* isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2))
* pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda pushed a commit to googleapis/google-cloud-node-core that referenced this pull request Oct 29, 2025
🤖 I have created a release *beep* *boop*
---


### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03)


### Bug Fixes

* handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805))
* isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2))
* pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda pushed a commit to googleapis/google-cloud-node-core that referenced this pull request Oct 29, 2025
🤖 I have created a release *beep* *boop*
---


### [2.30.3](googleapis/gax-nodejs@v2.30.2...v2.30.3) (2022-05-03)


### Bug Fixes

* handle stream callback is undefined ([#1238](googleapis/gax-nodejs#1238)) ([269f805](googleapis/gax-nodejs@269f805))
* isolate Rest Stream from retry logic to avoid backpressure ([#1226](googleapis/gax-nodejs#1226)) ([485d5b2](googleapis/gax-nodejs@485d5b2))
* pin @grpc/proto-loader to v0.6.9 ([#1242](googleapis/gax-nodejs#1242)) ([bca9a91](googleapis/gax-nodejs@bca9a91))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants