Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: revert gRPC stream change in #1226#1257

Merged
summer-ji-eng merged 4 commits intomainfrom
stream_close
May 9, 2022
Merged

fix: revert gRPC stream change in #1226#1257
summer-ji-eng merged 4 commits intomainfrom
stream_close

Conversation

@summer-ji-eng
Copy link
Contributor

Moving out lines from the retryStream cause failing to emit the closed client error.

const stream = apiCall(argument, this._callback) as CancellableStream;
this.stream = stream

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 6, 2022 19:03
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 6, 2022
@summer-ji-eng summer-ji-eng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2022
@summer-ji-eng summer-ji-eng merged commit 1c3a5a7 into main May 9, 2022
@summer-ji-eng summer-ji-eng deleted the stream_close branch May 9, 2022 17:33
summer-ji-eng added a commit that referenced this pull request May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants