[tests] Merge UI test directories by joshlf · Pull Request #2997 · google/zerocopy

joshlf · 2026-02-06T02:41:51Z

Now, UI test source and stderr files live in a structure like:

ui/foo.rs
ui/foo.msrv.stderr
ui/foo.stable.stderr
ui/foo.nightly.stderr

Makes progress on #2999

Latest Update: v9 — Compare vs v8

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v8	v7	v6	v5	v4	v3	v2	v1	Base
v9	v8	v7	v6	v5	v4	v3	v2	v1	Base
v8		v7	v6	v5	v4	v3	v2	v1	Base
v7			v6	v5	v4	v3	v2	v1	Base
v6				v5	v4	v3	v2	v1	Base
v5					v4	v3	v2	v1	Base
v4						v3	v2	v1	Base
v3							v2	v1	Base
v2								v1	Base
v1									Base

⬇️ Download this PR

Branch

git fetch origin refs/heads/G89ee46d6a1d97f48811d710599b089f486c85717 && git checkout -b pr-G89ee46d6a1d97f48811d710599b089f486c85717 FETCH_HEAD

Checkout

git fetch origin refs/heads/G89ee46d6a1d97f48811d710599b089f486c85717 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G89ee46d6a1d97f48811d710599b089f486c85717 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G89ee46d6a1d97f48811d710599b089f486c85717

Stacked PRs enabled by GHerrit.

gemini-code-assist · 2026-02-06T02:43:11Z

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the organization of UI test files by consolidating them into a single directory and encoding toolchain-specific information directly within the filenames. This refactoring simplifies the test suite's directory structure and updates the test runner to correctly interpret these new file paths, enhancing overall test maintainability and clarity.

Highlights

UI Test File Consolidation: UI test source files (.rs) and their corresponding error output files (.stderr) have been moved from separate toolchain-specific directories (e.g., ui-msrv, ui-stable, ui-nightly) into a single, unified ui directory.
Toolchain Information in Filenames: The toolchain specificity (MSRV, stable, nightly) is now embedded directly into the filenames as suffixes (e.g., testname.msrv.stderr) rather than being indicated by the directory structure.
UI Test Runner Adaptation: The UI test runner has been updated to pass and consume a new environment variable, ZEROCOPY_UI_TEST_TOOLCHAIN_CATEGORY, which allows it to correctly identify and configure the target toolchain for tests within the new consolidated file structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

tests/ui-msrv/*.rs
- Removed numerous symbolic link-like files that pointed to ui-nightly versions.
tests/ui-msrv/*.stderr
- Renamed to tests/ui/*.msrv.stderr to consolidate files and embed toolchain info.
tests/ui-nightly/*.rs
- Renamed to tests/ui/*.rs to consolidate source files into a single directory.
tests/ui-nightly/*.stderr
- Renamed to tests/ui/*.nightly.stderr to consolidate files and embed toolchain info.
tests/ui-stable/*.rs
- Removed numerous symbolic link-like files that pointed to ui-nightly versions.
tests/ui-stable/*.stderr
- Renamed to tests/ui/*.stable.stderr to consolidate files and embed toolchain info.
testutil/src/lib.rs
- Added ZEROCOPY_UI_TEST_TOOLCHAIN_CATEGORY environment variable to UI test commands.
tools/ui-runner/src/main.rs
- Modified to read the ZEROCOPY_UI_TEST_TOOLCHAIN_CATEGORY environment variable and set config.host accordingly.
zerocopy-derive/tests/ui-msrv/*.rs
- Removed numerous symbolic link-like files, similar to the top-level tests/ui-msrv files.

Activity

This pull request is part of a series of stacked PRs, indicated by references to [tests] Merge UI test directories #2997, [tests] Delete disabled test file #2996, and [tests] Migrate from trybuild to ui-test #2994.
The PR description was automatically generated by GHerrit, a tool for managing stacked pull requests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

codecov-commenter · 2026-02-06T02:45:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (350f32c) to head (20a5e50).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          20       20           
  Lines        6057     6057           
=======================================
  Hits         5565     5565           
  Misses        492      492

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gemini-code-assist

Code Review

This pull request refactors the UI test file structure to be more organized by coalescing test files into a single tests/ui directory. The changes to the test runners to support this new structure are mostly correct. However, I've found a critical issue in testutil/src/lib.rs where the test source directory is still being set to the old, now non-existent, directories. This will prevent the tests from running correctly. I've left a detailed comment on this issue. Additionally, the documentation in agent_docs/ui_tests.md now describes an outdated workflow and should be updated to reflect these changes.

testutil/src/lib.rs

Now, UI test source and stderr files live in a structure like: - `ui/foo.rs` - `ui/foo.msrv.stderr` - `ui/foo.stable.stderr` - `ui/foo.nightly.stderr` Makes progress on #2999 gherrit-pr-id: G89ee46d6a1d97f48811d710599b089f486c85717

This was referenced Feb 6, 2026

[tests] Migrate from trybuild to ui-test #2994

Merged

[tests] Delete disabled test file #2996

Merged

gemini-code-assist bot reviewed Feb 6, 2026

View reviewed changes

testutil/src/lib.rs Outdated Show resolved Hide resolved

joshlf force-pushed the Gcfda5f0363b5a5e71c291bfc1a4ab75405ac6c13 branch from 59d89e5 to f5798e4 Compare February 6, 2026 03:03

joshlf force-pushed the G89ee46d6a1d97f48811d710599b089f486c85717 branch from 82760c4 to 4c0ace9 Compare February 6, 2026 03:03

joshlf mentioned this pull request Feb 6, 2026

[ci] Support XODO comments in commit messages #2998

Merged

joshlf changed the base branch from Gcfda5f0363b5a5e71c291bfc1a4ab75405ac6c13 to Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe February 6, 2026 03:03

joshlf force-pushed the Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe branch from 3ead393 to 8e29e49 Compare February 6, 2026 03:06

joshlf force-pushed the G89ee46d6a1d97f48811d710599b089f486c85717 branch from 4c0ace9 to 8b89725 Compare February 6, 2026 03:06

joshlf mentioned this pull request Feb 6, 2026

Improve ui-test setup #2999

Open

joshlf force-pushed the G89ee46d6a1d97f48811d710599b089f486c85717 branch 2 times, most recently from 79af3ee to 265232e Compare February 6, 2026 18:25

joshlf force-pushed the Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe branch from 8e29e49 to 4b2ee00 Compare February 6, 2026 18:33

Base automatically changed from Gc456c89ea3f26105fca5cadcd11ddc5107ed6afe to main February 6, 2026 19:06

joshlf force-pushed the G89ee46d6a1d97f48811d710599b089f486c85717 branch from 265232e to 06ac251 Compare February 6, 2026 19:06

joshlf mentioned this pull request Feb 6, 2026

[tests] Annotate UI test files with error requirements #3000

Merged

joshlf enabled auto-merge February 6, 2026 19:07

[tests] Merge UI test directories

20a5e50

Now, UI test source and stderr files live in a structure like: - `ui/foo.rs` - `ui/foo.msrv.stderr` - `ui/foo.stable.stderr` - `ui/foo.nightly.stderr` Makes progress on #2999 gherrit-pr-id: G89ee46d6a1d97f48811d710599b089f486c85717

joshlf force-pushed the G89ee46d6a1d97f48811d710599b089f486c85717 branch from 06ac251 to 20a5e50 Compare February 6, 2026 19:44

joshlf changed the title ~~[tests] Coalesce UI test files~~ [tests] Merge UI test directories Feb 6, 2026

joshlf mentioned this pull request Feb 6, 2026

[tests] Coalesce UI test files #3001

Merged

joshlf requested a review from jswrenn February 6, 2026 19:44

jswrenn approved these changes Feb 6, 2026

View reviewed changes

joshlf added this pull request to the merge queue Feb 6, 2026

Merged via the queue into main with commit 4070001 Feb 6, 2026
104 checks passed

joshlf deleted the G89ee46d6a1d97f48811d710599b089f486c85717 branch February 6, 2026 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests] Merge UI test directories#2997

[tests] Merge UI test directories#2997
joshlf merged 1 commit intomainfrom
G89ee46d6a1d97f48811d710599b089f486c85717

joshlf commented Feb 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 6, 2026

Uh oh!

codecov-commenter commented Feb 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joshlf commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

codecov-commenter commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joshlf commented Feb 6, 2026 •

edited

Loading

codecov-commenter commented Feb 6, 2026 •

edited

Loading