Merged
Conversation
Contributor
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request overhauls the project's UI testing setup by transitioning from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the UI testing framework from trybuild to ui-test. This is a substantial and valuable change, involving the addition of a new ui-runner tool, dependency updates, and refreshing test output files. The new testing infrastructure appears well-thought-out. I've identified a couple of leftover debugging statements that should be removed before this is merged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2994 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 20 20
Lines 6057 6057
=======================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d3142b5 to
b580299
Compare
0e5b2bb to
98e33b6
Compare
403655a to
98fa755
Compare
Base automatically changed from
G56d361c99cff83d83a76462d778b02e43db0f26a
to
main
February 6, 2026 00:36
89a00c7 to
3974a23
Compare
jswrenn
approved these changes
Feb 6, 2026
Closed
Closes #187 gherrit-pr-id: Ga906feb9ce7223d10a874a61cadc6025cd4275d5
3974a23 to
a08607e
Compare
This was referenced Feb 6, 2026
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
Latest Update: v12 — Compare vs v11
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Ga906feb9ce7223d10a874a61cadc6025cd4275d5 && git checkout -b pr-Ga906feb9ce7223d10a874a61cadc6025cd4275d5 FETCH_HEADCheckout
git fetch origin refs/heads/Ga906feb9ce7223d10a874a61cadc6025cd4275d5 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Ga906feb9ce7223d10a874a61cadc6025cd4275d5 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.