[tests] Coalesce UI test files by joshlf · Pull Request #3001 · google/zerocopy

joshlf · 2026-02-06T19:44:20Z

Now that we're using ui-test's inline annotations, it is not risky to
coalesce many tests in a single file.

Makes progress on #2999

👉 [tests] Coalesce UI test files #3001

Latest Update: v4 — Compare vs v3

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v3	v2	v1	Base
v4	vs v3	vs v2	vs v1	vs Base
v3		vs v2	vs v1	vs Base
v2			vs v1	vs Base
v1				vs Base

⬇️ Download this PR

Branch

git fetch origin refs/heads/G25fee321cbc44905c61a0065546e8d58bfaff20f && git checkout -b pr-G25fee321cbc44905c61a0065546e8d58bfaff20f FETCH_HEAD

Checkout

git fetch origin refs/heads/G25fee321cbc44905c61a0065546e8d58bfaff20f && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G25fee321cbc44905c61a0065546e8d58bfaff20f && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G25fee321cbc44905c61a0065546e8d58bfaff20f

Stacked PRs enabled by GHerrit.

gemini-code-assist · 2026-02-06T19:46:21Z

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the UI testing suite by consolidating many small, individual test files into a few larger, more organized files. This change is facilitated by the adoption of ui-test's inline annotations, which allows for multiple test cases to be safely grouped within a single file. The primary goal is to streamline the test setup and maintenance, contributing to a more robust and efficient testing environment.

Highlights

Test Consolidation: Numerous individual UI test files have been merged into a smaller set of consolidated files, improving test organization.
Inline Annotations: This consolidation was made possible and safe by leveraging ui-test's inline annotations feature.
Issue Progress: This change contributes to the ongoing work tracked in issue Improve ui-test setup #2999, which likely involves improvements to the testing infrastructure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

tests/ui/transmute-dst-not-frombytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-dst-not-frombytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-dst-not-frombytes.rs
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-dst-not-frombytes.stable.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-mut-const.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-const.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-const.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-const.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-a-reference.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-a-reference.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-a-reference.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-a-reference.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-frombytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-frombytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-frombytes.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-frombytes.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-intobytes.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-dst-not-intobytes.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-illegal-lifetime.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-illegal-lifetime.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-illegal-lifetime.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-illegal-lifetime.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-dst-not-references.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-dst-not-references.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-dst-not-references.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-dst-not-references.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-immutable.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-immutable.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-immutable.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-immutable.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-a-reference.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-a-reference.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-a-reference.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-a-reference.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-frombytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-frombytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-frombytes.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-frombytes.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-intobytes.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-not-intobytes.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-unsized.msrv.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-unsized.nightly.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-unsized.rs
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-mut-src-unsized.stable.stderr
- Removed, its content is now part of the consolidated transmute_mut.rs test suite.
tests/ui/transmute-ptr-to-usize.msrv.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-ptr-to-usize.nightly.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-ptr-to-usize.rs
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-ptr-to-usize.stable.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-ref-dst-mutable.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-mutable.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-mutable.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-mutable.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-a-reference.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-a-reference.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-a-reference.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-a-reference.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-frombytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-frombytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-frombytes.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-frombytes.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-nocell.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-nocell.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-nocell.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-dst-not-nocell.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-illegal-lifetime.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-illegal-lifetime.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-illegal-lifetime.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-illegal-lifetime.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-dst-not-references.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-dst-not-references.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-dst-not-references.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-dst-not-references.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-a-reference.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-a-reference.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-a-reference.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-a-reference.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-intobytes.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-intobytes.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-nocell.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-nocell.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-nocell.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-not-nocell.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-unsized.msrv.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-unsized.nightly.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-unsized.rs
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-ref-src-unsized.stable.stderr
- Removed, its content is now part of the consolidated transmute_ref.rs test suite.
tests/ui/transmute-size-decrease.msrv.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-decrease.nightly.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-decrease.rs
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-decrease.stable.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase-allow-shrink.msrv.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase-allow-shrink.nightly.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase-allow-shrink.rs
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase-allow-shrink.stable.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase.msrv.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase.nightly.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase.rs
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-size-increase.stable.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-src-not-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-src-not-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-src-not-intobytes.rs
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute-src-not-intobytes.stable.stderr
- Removed, its content is now part of the consolidated transmute.rs test suite.
tests/ui/transmute.msrv.stderr
- Added, containing merged UI test stderr output for the transmute macro on the MSRV toolchain.
tests/ui/transmute.nightly.stderr
- Added, containing merged UI test stderr output for the transmute macro on the nightly toolchain.
tests/ui/transmute.rs
- Added, consolidating multiple UI tests related to the transmute macro, including cases for destination type trait bounds, size changes, source type trait bounds, and pointer transmutations.
tests/ui/transmute.stable.stderr
- Added, containing merged UI test stderr output for the transmute macro on the stable toolchain.
tests/ui/transmute_mut.msrv.stderr
- Added, containing merged UI test stderr output for the transmute_mut macro on the MSRV toolchain.
tests/ui/transmute_mut.nightly.stderr
- Added, containing merged UI test stderr output for the transmute_mut macro on the nightly toolchain.
tests/ui/transmute_mut.rs
- Added, consolidating multiple UI tests related to the transmute_mut macro, covering scenarios like const contexts, non-reference destination types, trait bound checks for FromBytes and IntoBytes on source and destination, lifetime issues, immutable sources, and unsized sources.
tests/ui/transmute_mut.stable.stderr
- Added, containing merged UI test stderr output for the transmute_mut macro on the stable toolchain.
tests/ui/transmute_ref.msrv.stderr
- Added, containing merged UI test stderr output for the transmute_ref macro on the MSRV toolchain.
tests/ui/transmute_ref.nightly.stderr
- Added, containing merged UI test stderr output for the transmute_ref macro on the nightly toolchain.
tests/ui/transmute_ref.rs
- Added, consolidating multiple UI tests related to the transmute_ref macro, including checks for mutable destination references, non-reference destination types, trait bound checks for FromBytes and Immutable on destination, lifetime issues, non-reference source types, and trait bound checks for IntoBytes and Immutable on source.
tests/ui/transmute_ref.stable.stderr
- Added, containing merged UI test stderr output for the transmute_ref macro on the stable toolchain.
tests/ui/try_transmute-dst-not-tryfrombytes.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-dst-not-tryfrombytes.rs
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-dst-not-tryfrombytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-decrease.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-decrease.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-decrease.rs
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-decrease.stable.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-increase.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-increase.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-increase.rs
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-size-increase.stable.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-src-not-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-src-not-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-src-not-intobytes.rs
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute-src-not-intobytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute.rs test suite.
tests/ui/try_transmute.msrv.stderr
- Renamed from tests/ui/try_transmute-dst-not-tryfrombytes.msrv.stderr and updated to include merged UI test stderr output for the try_transmute macro on the MSRV toolchain.
tests/ui/try_transmute.nightly.stderr
- Added, containing merged UI test stderr output for the try_transmute macro on the nightly toolchain.
tests/ui/try_transmute.rs
- Added, consolidating multiple UI tests related to the try_transmute macro, including checks for destination type trait bounds, size changes, and source type trait bounds.
tests/ui/try_transmute.stable.stderr
- Added, containing merged UI test stderr output for the try_transmute macro on the stable toolchain.
tests/ui/try_transmute_mut-dst-not-tryfrombytes.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-dst-not-tryfrombytes.nightly.stderr
- Renamed from tests/ui/try_transmute_mut-dst-not-tryfrombytes.nightly.stderr and updated to include merged UI test stderr output for the try_transmute_mut macro on the nightly toolchain.
tests/ui/try_transmute_mut-dst-not-tryfrombytes.rs
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-dst-not-tryfrombytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-frombytes.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-frombytes.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-frombytes.rs
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-frombytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-intobytes.rs
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut-src-not-intobytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute_mut.rs test suite.
tests/ui/try_transmute_mut.msrv.stderr
- Added, containing merged UI test stderr output for the try_transmute_mut macro on the MSRV toolchain.
tests/ui/try_transmute_mut.nightly.stderr
- Added, containing merged UI test stderr output for the try_transmute_mut macro on the nightly toolchain.
tests/ui/try_transmute_mut.rs
- Added, consolidating multiple UI tests related to the try_transmute_mut macro, covering trait bound checks for TryFromBytes, IntoBytes, and FromBytes on source and destination types.
tests/ui/try_transmute_mut.stable.stderr
- Added, containing merged UI test stderr output for the try_transmute_mut macro on the stable toolchain.
tests/ui/try_transmute_ref-dst-mutable.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-mutable.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-mutable.rs
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-mutable.stable.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-not-immutable-tryfrombytes.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-not-immutable-tryfrombytes.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-not-immutable-tryfrombytes.rs
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-dst-not-immutable-tryfrombytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-src-not-immutable-intobytes.msrv.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-src-not-immutable-intobytes.nightly.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref-src-not-immutable-intobytes.stable.stderr
- Removed, its content is now part of the consolidated try_transmute_ref.rs test suite.
tests/ui/try_transmute_ref.msrv.stderr
- Added, containing merged UI test stderr output for the try_transmute_ref macro on the MSRV toolchain.
tests/ui/try_transmute_ref.nightly.stderr
- Added, containing merged UI test stderr output for the try_transmute_ref macro on the nightly toolchain.
tests/ui/try_transmute_ref.rs
- Renamed from tests/ui/try_transmute_ref-src-not-immutable-intobytes.rs and updated to consolidate multiple UI tests related to the try_transmute_ref macro, including checks for mutable destination references, trait bound checks for TryFromBytes and Immutable on destination, and trait bound checks for IntoBytes and Immutable on source.
tests/ui/try_transmute_ref.stable.stderr
- Added, containing merged UI test stderr output for the try_transmute_ref macro on the stable toolchain.

Activity

This pull request was automatically generated by GHerrit, indicating it is part of a stacked series of changes.
No human activity (comments, reviews, or direct pushes) has been recorded on this specific pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

codecov-commenter · 2026-02-06T19:46:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (01126da) to head (2e21863).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3001   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          20       20           
  Lines        6057     6057           
=======================================
  Hits         5565     5565           
  Misses        492      492

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gemini-code-assist

Code Review

This pull request is a nice refactoring that coalesces many small UI test files into a few larger ones, which should improve maintainability. The changes are mostly good, but I've found a couple of issues.

There's a critical issue in tests/ui/try_transmute_mut.rs where two test functions are broken due to missing type definitions and incorrect macro usage, causing compilation failures. I've suggested removing or fixing them.

I also found a minor issue in tests/ui/transmute_mut.rs with an unused import that should be removed for code cleanliness. Other than these points, the refactoring looks solid.

tests/ui/try_transmute_mut.rs

tests/ui/transmute_mut.rs

Now that we're using ui-test's inline annotations, it is not risky to coalesce many tests in a single file. Makes progress on #2999 gherrit-pr-id: G25fee321cbc44905c61a0065546e8d58bfaff20f

This was referenced Feb 6, 2026

[tests] Merge UI test directories #2997

Merged

[tests] Annotate UI test files with error requirements #3000

Merged

joshlf requested a review from jswrenn February 6, 2026 19:44

gemini-code-assist bot reviewed Feb 6, 2026

View reviewed changes

tests/ui/try_transmute_mut.rs Outdated Show resolved Hide resolved

tests/ui/transmute_mut.rs Outdated Show resolved Hide resolved

jswrenn approved these changes Feb 6, 2026

View reviewed changes

joshlf force-pushed the G25fee321cbc44905c61a0065546e8d58bfaff20f branch from 19fec81 to 651635f Compare February 6, 2026 20:02

joshlf force-pushed the G3638fc706fe75313ba5202a53db61e78b5243a1f branch 4 times, most recently from eb4b425 to f33f472 Compare February 9, 2026 19:37

Base automatically changed from G3638fc706fe75313ba5202a53db61e78b5243a1f to main February 9, 2026 21:34

joshlf mentioned this pull request Feb 9, 2026

try_transmute! "cannot transmute between types of different sizes" not triggered in UI tests #3024

Closed

joshlf force-pushed the G25fee321cbc44905c61a0065546e8d58bfaff20f branch from 651635f to 2400630 Compare February 9, 2026 22:25

joshlf enabled auto-merge February 9, 2026 22:25

[tests] Coalesce UI test files

2e21863

Now that we're using ui-test's inline annotations, it is not risky to coalesce many tests in a single file. Makes progress on #2999 gherrit-pr-id: G25fee321cbc44905c61a0065546e8d58bfaff20f

joshlf force-pushed the G25fee321cbc44905c61a0065546e8d58bfaff20f branch from 2400630 to 2e21863 Compare February 9, 2026 22:29

joshlf added this pull request to the merge queue Feb 9, 2026

Merged via the queue into main with commit 4fe6388 Feb 9, 2026
175 of 205 checks passed

joshlf deleted the G25fee321cbc44905c61a0065546e8d58bfaff20f branch February 9, 2026 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests] Coalesce UI test files#3001

[tests] Coalesce UI test files#3001
joshlf merged 1 commit intomainfrom
G25fee321cbc44905c61a0065546e8d58bfaff20f

joshlf commented Feb 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 6, 2026

Uh oh!

codecov-commenter commented Feb 6, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joshlf commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

codecov-commenter commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joshlf commented Feb 6, 2026 •

edited

Loading

codecov-commenter commented Feb 6, 2026 •

edited

Loading