Skip to content

providers/ldap: add windows adsi support#7098

Merged
BeryJu merged 4 commits intogoauthentik:mainfrom
vherrlein:feature/WIP-LDAP-Outpost-Windows-ADSI-Support
Oct 9, 2023
Merged

providers/ldap: add windows adsi support#7098
BeryJu merged 4 commits intogoauthentik:mainfrom
vherrlein:feature/WIP-LDAP-Outpost-Windows-ADSI-Support

Conversation

@vherrlein
Copy link
Contributor

@vherrlein vherrlein commented Oct 8, 2023

Details

closes #5307
closes #5838
closes #5904

Changes

  • Add missing LDAP Object Classes
  • Add Sub Schema Attributes
  • Update LDAP Schema definition

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

* add "person" object class
* update user object classes
* update boolean strings to upper for being compliant

tags: WIP-LDAP-Outpost-Windows-ADSI-Support
* add supported capability OIDs for Windows
* add relevant supported ldap control OIDs

tags: WIP-LDAP-Outpost-Windows-ADSI-Support
* add relevant dITContentRules for authentik
* add all existing attribute types for Windows/Unix/Linux
* add missing object classes definitions
* update classes definitions for being compliant with LDAP schema
* update attributes orders

tags: WIP-LDAP-Outpost-Windows-ADSI-Support
@vherrlein vherrlein requested a review from a team as a code owner October 8, 2023 10:46
@netlify
Copy link

netlify bot commented Oct 8, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 7d30092
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65239c264de03f0009b61b40
😎 Deploy Preview https://deploy-preview-7098--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vherrlein
Copy link
Contributor Author

vherrlein commented Oct 8, 2023

Finnaly it's working :)

User search result:
image

Group search result:
image

* remove unsused attribute types
* order attribute types

tags: WIP-LDAP-Outpost-Windows-ADSI-Support
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b90ed6b) 92.68% compared to head (7d30092) 92.67%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7098      +/-   ##
==========================================
- Coverage   92.68%   92.67%   -0.00%     
==========================================
  Files         567      568       +1     
  Lines       28014    28049      +35     
==========================================
+ Hits        25961    25993      +32     
- Misses       2053     2056       +3     
Flag Coverage Δ
e2e 51.19% <ø> (+0.04%) ⬆️
integration 26.34% <ø> (+0.05%) ⬆️
unit 89.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit f11bb8b into goauthentik:main Oct 9, 2023
kensternberg-authentik added a commit that referenced this pull request Oct 9, 2023
* main: (22 commits)
  lifecycle: fix install_id migration not running (#7116)
  core: bump Go from 1.20 to 1.21 (#7117)
  providers/ldap: add windows adsi support (#7098)
  web: bump API Client version (#7113)
  translate: Updates for file web/xliff/en.xlf in zh-Hans on branch main (#7112)
  translate: Updates for file web/xliff/en.xlf in zh_CN on branch main (#7111)
  web: bump the wdio group in /tests/wdio with 4 updates (#7108)
  core/api: add uuid field to core api user http response (#7110)
  core: bump goauthentik.io/api/v3 from 3.2023083.4 to 3.2023083.5 (#7105)
  core: bump golang.org/x/oauth2 from 0.12.0 to 0.13.0 (#7106)
  web: bump the eslint group in /tests/wdio with 1 update (#7107)
  providers/proxy: improve SLO by backchannel logging out sessions (#7099)
  web: bump @rollup/plugin-node-resolve from 15.2.2 to 15.2.3 in /web (#7104)
  web: bump the eslint group in /web with 1 update (#7103)
  web: bump the storybook group in /web with 1 update (#7102)
  web: bump API Client version (#7101)
  providers/saml: add default RelayState value for IDP-initiated requests (#7100)
  lifecycle: improve reliability of system migrations (#7089)
  sources/ldap: fix attribute path resolution (#7090)
  root: Ignore the vendor folder (#7094)
  ...
kensternberg-authentik added a commit that referenced this pull request Oct 9, 2023
* main: (41 commits)
  lifecycle: fix install_id migration not running (#7116)
  core: bump Go from 1.20 to 1.21 (#7117)
  providers/ldap: add windows adsi support (#7098)
  web: bump API Client version (#7113)
  translate: Updates for file web/xliff/en.xlf in zh-Hans on branch main (#7112)
  translate: Updates for file web/xliff/en.xlf in zh_CN on branch main (#7111)
  web: bump the wdio group in /tests/wdio with 4 updates (#7108)
  core/api: add uuid field to core api user http response (#7110)
  core: bump goauthentik.io/api/v3 from 3.2023083.4 to 3.2023083.5 (#7105)
  core: bump golang.org/x/oauth2 from 0.12.0 to 0.13.0 (#7106)
  web: bump the eslint group in /tests/wdio with 1 update (#7107)
  providers/proxy: improve SLO by backchannel logging out sessions (#7099)
  web: bump @rollup/plugin-node-resolve from 15.2.2 to 15.2.3 in /web (#7104)
  web: bump the eslint group in /web with 1 update (#7103)
  web: bump the storybook group in /web with 1 update (#7102)
  web: bump API Client version (#7101)
  providers/saml: add default RelayState value for IDP-initiated requests (#7100)
  lifecycle: improve reliability of system migrations (#7089)
  sources/ldap: fix attribute path resolution (#7090)
  root: Ignore the vendor folder (#7094)
  ...
Copy link

@0vik7 0vik7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дубликат #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDAP Outpost: Create dynamic schema for custom attributes LDAP Outpost - Microsoft .NET Application using DirectoryEntry is failing

3 participants