Skip to content

providers/ldap: rework Schema and DSE#5838

Merged
BeryJu merged 17 commits intomainfrom
providers/ldap/rework
Jun 8, 2023
Merged

providers/ldap: rework Schema and DSE#5838
BeryJu merged 17 commits intomainfrom
providers/ldap/rework

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 2, 2023

Details

closes #5307
closes #3361

Changes

  • Correctly respond for the RootDSE
    • Try to get the correct provider not only based on search base DN but also base on the bind DN
    • Search requests for base DN "" will get a RootDSE based on the Bind DN
    • Search requests for base DN "" will default to a minimal RootDSE
  • Include an LDAP Schema for some custom types, this is still very much WIP

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner June 2, 2023 15:07
@BeryJu BeryJu force-pushed the providers/ldap/rework branch from 74d6423 to 805f6c6 Compare June 2, 2023 15:08
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.50 ⚠️

Comparison is base (e573b3a) 92.62% compared to head (79a7c3d) 92.11%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5838      +/-   ##
==========================================
- Coverage   92.62%   92.11%   -0.50%     
==========================================
  Files         549      549              
  Lines       26326    26326              
==========================================
- Hits        24382    24248     -134     
- Misses       1944     2078     +134
Flag Coverage Δ
e2e 50.23% <ø> (-1.67%) ⬇️
integration 26.48% <ø> (ø)
unit 89.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023 •
edited
Loading

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-ldap-rework-1686229865-79a7c3d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-providers-ldap-rework-1686229865-79a7c3d-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-ldap-rework-1686229865-79a7c3d

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-providers-ldap-rework-1686229865-79a7c3d-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the providers/ldap/rework branch 3 times, most recently from b98f8b3 to 04c49a2 Compare June 6, 2023 19:44
@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 79a7c3d
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6481d07f9ad9f60008784a3f

@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for authentik ready!

Name Link
🔨 Latest commit f7c51b8
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/6481bb6203d6e500081ee7ab
😎 Deploy Preview https://deploy-preview-5838--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@BeryJu BeryJu mentioned this pull request Jun 8, 2023
Open
@BeryJu BeryJu force-pushed the providers/ldap/rework branch from 9f10d20 to 8bc8614 Compare June 8, 2023 11:09
BeryJu added 14 commits June 8, 2023 13:28
@BeryJu
rework Root DSE
24cef87 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
always parse filter objectClass
adf025b 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
start adding LDAP Schema
6b3987f 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
add more schema
9bec866 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
update schema more
6c30060 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
fix cn for schema
e59598e 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
only include main DN in namingContexts
c1b0f2d 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
use schema from gh
c2f77d6 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
add description
96f6be7 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
add response filtering
7c8ebfd 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
fix response filtering
27fcf4f 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
don't return rootDSE entry when searching for singleLevel
8965834 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
remove currentTime
3234f8b 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
fix attribute filtering
f7c51b8 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/ldap/rework branch from 58dc1dc to f7c51b8 Compare June 8, 2023 11:28
BeryJu added 3 commits June 8, 2023 14:20
@BeryJu
fix tests
df273ab 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
set SINGLE-VALUE
5612b82 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
fix numbers
79a7c3d 
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 54ef88a into main Jun 8, 2023
@BeryJu BeryJu deleted the providers/ldap/rework branch June 8, 2023 13:16
kensternberg-authentik added a commit that referenced this pull request Jun 8, 2023
@kensternberg-authentik
Merge branch 'main' into 5165-password-strength-indicator
1c85dc5 
* main:
  providers/ldap: rework Schema and DSE (#5838)
  web/flows: update default flow background (#5905)
  web: bump @formatjs/intl-listformat from 7.2.2 to 7.3.0 in /web (#5866)
  website/integrations: add account linking note for WriteFreely (#5804)
  web: bump @storybook/addon-essentials from 7.0.18 to 7.0.20 in /web (#5894)
  web: bump @storybook/web-components-vite from 7.0.18 to 7.0.20 in /web (#5895)
  web: bump @storybook/blocks from 7.0.18 to 7.0.20 in /web (#5893)
  web: bump storybook from 7.0.18 to 7.0.20 in /web (#5896)
  website/docs: correct LDAP StartTLS documentation (#5886)
  core: bump python from 3.11.3-slim-bullseye to 3.11.4-slim-bullseye (#5891)
  ci: bump docker/setup-qemu-action from 2.1.0 to 2.2.0 (#5892)
  core: bump selenium from 4.9.1 to 4.10.0 (#5897)
  web: bump pyright from 1.1.312 to 1.1.313 in /web (#5898)
  web: bump @storybook/addon-links from 7.0.18 to 7.0.20 in /web (#5899)
  web: bump @storybook/web-components from 7.0.18 to 7.0.20 in /web (#5900)
  core: bump urllib3 from 2.0.2 to 2.0.3 (#5901)
  core: bump ruff from 0.0.271 to 0.0.272 (#5902)
  core: bump sentry-sdk from 1.25.0 to 1.25.1 (#5903)
@BeryJu BeryJu restored the providers/ldap/rework branch July 7, 2023 21:59
@BeryJu BeryJu deleted the providers/ldap/rework branch September 26, 2023 21:51
@vherrlein vherrlein mentioned this pull request Oct 8, 2023
Merged
7 tasks
@BeryJu BeryJu mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LDAP Outpost - Microsoft .NET Application using DirectoryEntry is failing [BUG, LDAP outpost] RootDSE search not functional

1 participant

@BeryJu