Conversation
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #6017 +/- ##
==========================================
+ Coverage 92.46% 92.46% +0.01%
==========================================
Files 561 561
Lines 27083 27092 +9
==========================================
+ Hits 25039 25048 +9
Misses 2044 2044
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-core-rework-groups-1692368361-95e60a0
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sFor arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-core-rework-groups-1692368361-95e60a0-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-core-rework-groups-1692368361-95e60a0For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-core-rework-groups-1692368361-95e60a0-arm64Afterwards, run the upgrade commands from the latest release notes. |
1e28c4a to
35cf681
Compare
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…l list of groups Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
67cf590 to
1a2ddd6
Compare
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
7 tasks
kensternberg-authentik
added a commit
that referenced
this pull request
Aug 21, 2023
* main: (70 commits) core: hotfix group membership check (#6584) web: bump core-js from 3.32.0 to 3.32.1 in /web (#6581) web: bump tslib from 2.6.1 to 2.6.2 in /web (#6583) web: bump the storybook group in /web with 5 updates (#6580) web/flows: update flow background (#6579) translate: Updates for file web/xliff/en.xlf in zh_CN on branch main (#6575) core: rework recursive group membership (#6017) core: bump goauthentik.io/api/v3 from 3.2023061.11 to 3.2023061.12 (#6572) core: bump ruff from 0.0.284 to 0.0.285 (#6570) ci: bump actions/setup-node from 3.8.0 to 3.8.1 blueprints: fix blueprint importer logging potentially sensitive data (#6567) web: bump API Client version (#6568) stages/authenticator_static: make static token size adjustable (#6565) root: always use persistent database connections (#6560) website/blog: identity fun (#6564) web: bump the storybook group in /web with 1 update (#6561) web: bump @rollup/plugin-node-resolve from 15.1.0 to 15.2.0 in /web (#6562) web: bump @lit-labs/task from 3.0.0 to 3.0.1 in /web (#6544) web: bump prettier from 3.0.1 to 3.0.2 in /web (#6549) web: bump the storybook group in /web with 5 updates (#6559) ...
pklaschka
added a commit
to pklaschka/authentik
that referenced
this pull request
Nov 24, 2024
…membership While for role memberships, it is true that they are only applied for _direct_ memberships, this does not appear to be the case for attributes (which is good as this also follows the "Hierarchy" system documented in the same file). In terms of the implementation, this is the case due to the call to `all_groups()` in https://github.com/goauthentik/authentik/blob/3d5a189fa732ef462dbbd73b88c128ebaf1833f9/authentik/core/models.py#L312-L313, introduced in goauthentik#6017. Looking through the files in there, it is clear that this line in the documentation is from before that point: https://github.com/goauthentik/authentik/blob/95e60a035df11d6f89db18cba3ae978d13d212b8/website/docs/user-group/group.md?plain=1#L15. tl;dr: the documentation was correct before goauthentik#6017, but is now out of date. This change fixes that. Signed-off-by: Zuri Klaschka <pklaschka@users.noreply.github.com>
6 tasks
tanberry
pushed a commit
that referenced
this pull request
Nov 26, 2024
…membership (#12168) While for role memberships, it is true that they are only applied for _direct_ memberships, this does not appear to be the case for attributes (which is good as this also follows the "Hierarchy" system documented in the same file). In terms of the implementation, this is the case due to the call to `all_groups()` in https://github.com/goauthentik/authentik/blob/3d5a189fa732ef462dbbd73b88c128ebaf1833f9/authentik/core/models.py#L312-L313, introduced in #6017. Looking through the files in there, it is clear that this line in the documentation is from before that point: https://github.com/goauthentik/authentik/blob/95e60a035df11d6f89db18cba3ae978d13d212b8/website/docs/user-group/group.md?plain=1#L15. tl;dr: the documentation was correct before #6017, but is now out of date. This change fixes that. Signed-off-by: Zuri Klaschka <pklaschka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l list of groups
Details
Currently we can only check group membership recursively for access control
This PR changes it to get a list all all groups (direct and indirect) a user is member of
Needs a bunch of optimisationNeeds notes in the release notes about being a "breaking" change (not really breaking but a changed behaviour of a well defined API)
closes #5338
closes https://github.com/goauthentik/meta/issues/69
closes #6477
#6016, #3622, #1278, #3284
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)