Skip to content

blueprints: fix blueprint importer logging potentially sensitive data#6567

Merged
BeryJu merged 1 commit intomainfrom
blueprints/fix-logging-cleanse
Aug 17, 2023
Merged

blueprints: fix blueprint importer logging potentially sensitive data#6567
BeryJu merged 1 commit intomainfrom
blueprints/fix-logging-cleanse

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 17, 2023

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner August 17, 2023 21:50
@BeryJu BeryJu requested review from tanberry and removed request for a team August 17, 2023 21:50
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit bcd4ce4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64de96287f1ce40008a6142f
😎 Deploy Preview https://deploy-preview-6567--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10% ⚠️

Comparison is base (1d99ec9) 92.46% compared to head (bcd4ce4) 92.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6567      +/-   ##
==========================================
- Coverage   92.46%   92.35%   -0.10%     
==========================================
  Files         561      561              
  Lines       27080    27083       +3     
==========================================
- Hits        25038    25011      -27     
- Misses       2042     2072      +30     
Flag Coverage Δ
e2e 50.82% <100.00%> (-0.77%) ⬇️
integration 26.58% <100.00%> (+0.01%) ⬆️
unit 89.28% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
authentik/blueprints/v1/importer.py 90.41% <100.00%> (+0.05%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 42c21da into main Aug 17, 2023
@BeryJu BeryJu deleted the blueprints/fix-logging-cleanse branch August 17, 2023 23:33
kensternberg-authentik added a commit that referenced this pull request Aug 21, 2023
* main: (70 commits)
  core: hotfix group membership check (#6584)
  web: bump core-js from 3.32.0 to 3.32.1 in /web (#6581)
  web: bump tslib from 2.6.1 to 2.6.2 in /web (#6583)
  web: bump the storybook group in /web with 5 updates (#6580)
  web/flows: update flow background (#6579)
  translate: Updates for file web/xliff/en.xlf in zh_CN on branch main (#6575)
  core: rework recursive group membership (#6017)
  core: bump goauthentik.io/api/v3 from 3.2023061.11 to 3.2023061.12 (#6572)
  core: bump ruff from 0.0.284 to 0.0.285 (#6570)
  ci: bump actions/setup-node from 3.8.0 to 3.8.1
  blueprints: fix blueprint importer logging potentially sensitive data (#6567)
  web: bump API Client version (#6568)
  stages/authenticator_static: make static token size adjustable (#6565)
  root: always use persistent database connections (#6560)
  website/blog: identity fun (#6564)
  web: bump the storybook group in /web with 1 update (#6561)
  web: bump @rollup/plugin-node-resolve from 15.1.0 to 15.2.0 in /web (#6562)
  web: bump @lit-labs/task from 3.0.0 to 3.0.1 in /web (#6544)
  web: bump prettier from 3.0.1 to 3.0.2 in /web (#6549)
  web: bump the storybook group in /web with 5 updates (#6559)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant