Skip to content

core: prevent selecting a group as a parent of itself#6016

Merged
BeryJu merged 2 commits intomainfrom
core/group-improvements
Jun 20, 2023
Merged

core: prevent selecting a group as a parent of itself#6016
BeryJu merged 2 commits intomainfrom
core/group-improvements

Conversation

@BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 20, 2023

Details

Prevent (both at the API level and UI level) from selecting a group as a parent of itself

#5338

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner June 20, 2023 12:14
@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ee933cc
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6491ac53f913c800074dda07

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 91.67% and project coverage change: +0.03 🎉

Comparison is base (a4d3b5f) 92.56% compared to head (ee933cc) 92.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6016      +/-   ##
==========================================
+ Coverage   92.56%   92.59%   +0.03%     
==========================================
  Files         550      550              
  Lines       26474    26486      +12     
==========================================
+ Hits        24503    24521      +18     
+ Misses       1971     1965       -6     
Flag Coverage Δ
e2e 51.67% <16.67%> (+0.50%) ⬆️
integration 26.39% <0.00%> (-0.01%) ⬇️
unit 89.47% <91.67%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/core/api/groups.py 84.00% <85.72%> (+0.13%) ⬆️
authentik/core/tests/test_groups_api.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the core/group-improvements branch from 2112116 to ee933cc Compare June 20, 2023 13:40
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-core-group-improvements-1687270002-ee933cc
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-core-group-improvements-1687270002-ee933cc-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-core-group-improvements-1687270002-ee933cc

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-core-group-improvements-1687270002-ee933cc-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 93575a9 into main Jun 20, 2023
@BeryJu BeryJu deleted the core/group-improvements branch June 20, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant