Skip to content

sources/saml: properly catch InvalidSignature exception#19641

Merged
PeshekDotDev merged 1 commit intomainfrom
saml-sig-error-handling
Jan 21, 2026
Merged

sources/saml: properly catch InvalidSignature exception#19641
PeshekDotDev merged 1 commit intomainfrom
saml-sig-error-handling

Conversation

@PeshekDotDev
Copy link
Contributor

Details

Closes #16627


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@PeshekDotDev PeshekDotDev self-assigned this Jan 21, 2026
@PeshekDotDev PeshekDotDev requested a review from a team as a code owner January 21, 2026 07:39
@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit fa886c3
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/697082afe8c5840008eb1561
😎 Deploy Preview https://deploy-preview-19641--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 21, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit fa886c3
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/697082afaadb2b0008913577
😎 Deploy Preview https://deploy-preview-19641--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.20%. Comparing base (66d6d88) to head (fa886c3).
⚠️ Report is 12 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/sources/saml/views.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19641      +/-   ##
==========================================
- Coverage   93.27%   93.20%   -0.07%     
==========================================
  Files         949      949              
  Lines       52131    52131              
==========================================
- Hits        48624    48590      -34     
- Misses       3507     3541      +34     
Flag Coverage Δ
conformance 38.26% <50.00%> (+<0.01%) ⬆️
e2e 44.11% <50.00%> (+<0.01%) ⬆️
integration 23.16% <0.00%> (-0.06%) ⬇️
unit 91.52% <50.00%> (+<0.01%) ⬆️
unit-migrate 91.53% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-fa886c3cfc12808b522ad8f04c75e0a8f56aa804
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-fa886c3cfc12808b522ad8f04c75e0a8f56aa804

Afterwards, run the upgrade commands from the latest release notes.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in authentik Core Jan 21, 2026
@PeshekDotDev PeshekDotDev added the backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12 label Jan 21, 2026
@PeshekDotDev PeshekDotDev merged commit e69bb40 into main Jan 21, 2026
101 of 102 checks passed
@PeshekDotDev PeshekDotDev deleted the saml-sig-error-handling branch January 21, 2026 17:18
@github-project-automation github-project-automation bot moved this from In Progress to Done in authentik Core Jan 21, 2026
authentik-automation bot pushed a commit that referenced this pull request Jan 21, 2026
@authentik-automation
Copy link
Contributor

🍒 Cherry-pick to version-2025.12 created: #19650

kensternberg-authentik added a commit that referenced this pull request Jan 21, 2026
…experiment

* main:
  sources/saml: properly catch InvalidSignature exception (#19641)
  sources/saml: Set AuthnRequest ProtocolBinding to HTTP-POST instead of HTTP-Redirect (#17378)
  website/docs: update endpoint agent windows log location (#19645)
  core: bump library/node from 25.3.0-trixie to 25.4.0-trixie in /website (#19632)
  core, web: update translations (#19535)
  core: bump github.com/pires/go-proxyproto from 0.8.1 to 0.9.0 (#19628)
  core: bump django-stubs[compatible-mypy] from 5.2.8 to 5.2.9 (#19629)
  web: bump @types/react from 19.2.8 to 19.2.9 in /web in the react group across 1 directory (#19631)
  core: bump sentry-sdk from 2.49.0 to 2.50.0 (#19630)
  website/integrations: update qnap (#19644)
  website/docs: Update saml google workspace guide (#19624)
  web/elements: reduce spacing between collapsible form groups (#19627)
  web/forms: fix forms not resetting state when modal closes (#19562)
  web/user: fix Firefox for Android infinite render loop in user library (#19379)
BeryJu pushed a commit that referenced this pull request Jan 29, 2026
…19641 to version-2025.12) (#19650)

sources/saml: properly catch InvalidSignature exception (#19641)

Fix error catching

Co-authored-by: Connor Peshek <connor@connorpeshek.me>
Co-authored-by: Marcelo Elizeche Landó <marcelo@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2025.12 Add this label to PRs to backport changes to version-2025.12

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

SAML Source POST binding error

2 participants