sources/saml: Set AuthnRequest ProtocolBinding to HTTP-POST instead of HTTP-Redirect#17378
Merged
PeshekDotDev merged 2 commits intogoauthentik:mainfrom Jan 21, 2026
Merged
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-integrations canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17378 +/- ##
==========================================
+ Coverage 92.72% 93.06% +0.33%
==========================================
Files 857 870 +13
Lines 46608 49538 +2930
==========================================
+ Hits 43217 46102 +2885
- Misses 3391 3436 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
PeshekDotDev
approved these changes
Jan 21, 2026
Contributor
PeshekDotDev
left a comment
There was a problem hiding this comment.
Awesome catch, thank you @ikob!
rissson
approved these changes
Jan 21, 2026
authentik-automation bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
…f HTTP-Redirect (#17378) * Use HTTP-POST instead of HTTP-Redirect for ProtocolBinding attribute in AuthnRequest * Fix nits Signed-off-by: Katsushi Kobayashi <ikob@acm.org> --------- Signed-off-by: Katsushi Kobayashi <ikob@acm.org>
Contributor
|
🍒 Cherry-pick to |
kensternberg-authentik
added a commit
that referenced
this pull request
Jan 21, 2026
…experiment * main: sources/saml: properly catch InvalidSignature exception (#19641) sources/saml: Set AuthnRequest ProtocolBinding to HTTP-POST instead of HTTP-Redirect (#17378) website/docs: update endpoint agent windows log location (#19645) core: bump library/node from 25.3.0-trixie to 25.4.0-trixie in /website (#19632) core, web: update translations (#19535) core: bump github.com/pires/go-proxyproto from 0.8.1 to 0.9.0 (#19628) core: bump django-stubs[compatible-mypy] from 5.2.8 to 5.2.9 (#19629) web: bump @types/react from 19.2.8 to 19.2.9 in /web in the react group across 1 directory (#19631) core: bump sentry-sdk from 2.49.0 to 2.50.0 (#19630) website/integrations: update qnap (#19644) website/docs: Update saml google workspace guide (#19624) web/elements: reduce spacing between collapsible form groups (#19627) web/forms: fix forms not resetting state when modal closes (#19562) web/user: fix Firefox for Android infinite render loop in user library (#19379)
BeryJu
pushed a commit
that referenced
this pull request
Jan 22, 2026
…f HTTP-Redirect (cherry-pick #17378 to version-2025.12) (#19649) sources/saml: Set AuthnRequest ProtocolBinding to HTTP-POST instead of HTTP-Redirect (#17378) * Use HTTP-POST instead of HTTP-Redirect for ProtocolBinding attribute in AuthnRequest * Fix nits --------- Signed-off-by: Katsushi Kobayashi <ikob@acm.org> Co-authored-by: Katsushi Kobayashi <ikob@acm.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This patch aligns authentik’s SAML Source implementation with the SAML 2.0 specification.
In the SAML Source configuration, the SP metadata always declares the
AssertionConsumerService (ACS) binding as HTTP-POST, regardless of the
SingleSignOnService (SSO) binding. However, the actual AuthnRequest message
used the SSO binding as its ProtocolBinding attribute, resulting in
HTTP-Redirect being sent.
According to the OASIS SAML 2.0 specification, the HTTP-Redirect binding
MUST NOT be used for delivering the from the IdP to the SP:
While many IdPs will still prefer the ACS binding declared in the SP metadata,
this change aligns the AuthnRequest with the SAML 2.0 specification.
Hopefully close Hopefully close REDIRECT case issue at the step 1 of #16627
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)