web/user: fix Firefox for Android infinite render loop in user library#19379
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19379 +/- ##
==========================================
- Coverage 93.25% 93.22% -0.04%
==========================================
Files 949 949
Lines 52131 52131
==========================================
- Hits 48617 48600 -17
- Misses 3514 3531 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Gulianrdgd Thank you for putting this fix together! Despite a variety of hardware on hand, we've had some trouble replicating this bug. I've long suspected that the ARIA attributes are related, especially when an attribute references another element within the tree. I've pushed a commit to your branch which should retain the screen reader's announcing of search results, along with name of the active application if enter is pressed. Would it be possible if you tried this latest commit and confirmed that the page does not lock up? Thanks much 🙏 |
3bc87f1 to
580f209
Compare
|
I think the code you sent works! I have not had the bug anymore using the latest version. However, for some reason I am not seeing the icons I set up for my applications. The bug might be in the rendering of the images. However, this feels unlikely looking at the code. 
It is difficult to trigger the bug. When I restart authentik, everything is fine. Then after 15/30 minutes the page is completely unresponsive. But I have let it run for 2 hours, and it still works great. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
555e063 to
ca6d62e
Compare
|
@Gulianrdgd Thanks for the debugging info. I've rebase the branch to the latest main and enabled the live Otherwise this looks like a push in the right direction 🥳 |
|
Yeah still the same issue with the images not showing up. This is the error message I get: TypeError: can't access property "Media", R.AdminFileListUsageEnum is undefined
renderForm ApplicationForm.ts:191
renderFormWrapper Form.ts:423
renderVisible Form.ts:469
renderVisible ModelForm.ts:94
render Form.ts:477
render ModelForm.ts:115
update lit-element.ts:166I took a quick look around the issues and in my local branch but I could not really see anything obvious. |
|
Nevermind I am sure it is this: #19398. You can merge the ARIA changes! |
@Gulianrdgd the reason is that in the version of |
2647a58 to
3d2558b
Compare
Co-authored-by: Julian van der Horst <julianvanderhorst@pm.me> Co-authored-by: Teffen Ellis <teffen@goauthentik.io>
3d2558b to
9929685
Compare
#19379) web: Add ARIA fixes, live region reporting. Co-authored-by: Teffen Ellis <teffen@goauthentik.io>
|
🍒 Cherry-pick to |
…y (cherry-pick #19379 to version-2025.12) (#19626) web/user: fix Firefox for Android infinite render loop in user library (#19379) web: Add ARIA fixes, live region reporting. Co-authored-by: Julian van der Horst <45941668+Gulianrdgd@users.noreply.github.com> Co-authored-by: Teffen Ellis <teffen@goauthentik.io>
…experiment * main: sources/saml: properly catch InvalidSignature exception (#19641) sources/saml: Set AuthnRequest ProtocolBinding to HTTP-POST instead of HTTP-Redirect (#17378) website/docs: update endpoint agent windows log location (#19645) core: bump library/node from 25.3.0-trixie to 25.4.0-trixie in /website (#19632) core, web: update translations (#19535) core: bump github.com/pires/go-proxyproto from 0.8.1 to 0.9.0 (#19628) core: bump django-stubs[compatible-mypy] from 5.2.8 to 5.2.9 (#19629) web: bump @types/react from 19.2.8 to 19.2.9 in /web in the react group across 1 directory (#19631) core: bump sentry-sdk from 2.49.0 to 2.50.0 (#19630) website/integrations: update qnap (#19644) website/docs: Update saml google workspace guide (#19624) web/elements: reduce spacing between collapsible form groups (#19627) web/forms: fix forms not resetting state when modal closes (#19562) web/user: fix Firefox for Android infinite render loop in user library (#19379)
Details
Hopefully Fixes #17755.
I could not do a lot of testing but this seems to fix the issue for me.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)