Merged
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17940 +/- ##
==========================================
- Coverage 92.97% 92.97% -0.01%
==========================================
Files 894 894
Lines 48926 48926
==========================================
- Hits 45490 45488 -2
- Misses 3436 3438 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c200807 to
b4fc3bf
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-00d37b5e6ed8d09880536a7b3864d104ac5450b1
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-00d37b5e6ed8d09880536a7b3864d104ac5450b1Afterwards, run the upgrade commands from the latest release notes. |
b4fc3bf to
8e954e0
Compare
78448ad to
9284b2e
Compare
BeryJu
approved these changes
Nov 21, 2025
9284b2e to
00d37b5
Compare
Contributor
|
|
rissson
pushed a commit
that referenced
this pull request
Nov 27, 2025
…8373) Co-authored-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>
Contributor
|
|
rissson
pushed a commit
that referenced
this pull request
Nov 27, 2025
…8408) * web: Table row refinements (#17659) * web: Reset selection state after refresh. * web: Only select row when not expandable. * web: Only render expandable content when row is expanded. * web: Use `repeat` directive. * web: Fix nested pointer event detection. * web: Fix issues surrounding stale table rows. * Port row selector fix. --------- Co-authored-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com> Co-authored-by: Teffen Ellis <teffen@goauthentik.io>
This was referenced Nov 27, 2025
Open
kensternberg-authentik
added a commit
that referenced
this pull request
Dec 11, 2025
* main: (58 commits) core: bump goauthentik.io/api/v3 from 3.2025120.5 to 3.2025120.7 (#18381) web/admin: add entitlement search (#18291) core: bump goauthentik/fips-debian from `8b7e8d0` to `8c4ec98` (#18361) website: bump the build group in /website with 3 updates (#18382) core: bump astral-sh/uv from 0.9.11 to 0.9.12 (#18383) root: improve testing helpers (#18379) website: bump the goauthentik group across 1 directory with 4 updates (#18378) website: bump the eslint group in /website with 3 updates (#18356) policies: use flow planner directly in PolicyAccessView to directly set flow context (#18372) providers/scim: fix PATCH for AWS (#18230) enterprise/providers/scim: fix OAuth (#18358) web: Fix stale table rows (#17940) web: Bump packages. (#18371) *: convert slugfields to textfields (#17411) outposts: set container healthcheck inline (#18298) web: ESLint Typing Fixes (#18362) core: bump golang.org/x/crypto from 0.43.0 to 0.45.0 (#18275) lifecycle/aws: bump aws-cdk from 2.1032.0 to 2.1033.0 in /lifecycle/aws (#18278) core: bump github.com/getsentry/sentry-go from 0.38.0 to 0.39.0 (#18353) ci: bump actions/setup-python from 6.0.0 to 6.1.0 in /.github/actions/setup (#18360) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes a few rendering memoization issues which can result in stale table rows, along with some additional fixes to avoid unnecessary re-rendering of table elements.
Why no
repeatdirective?While this initially seemed like a quick performance boost, I'm not so confident that the flexibility we expect of the table component is compatible with
repeat's expectations of stable keys. This issue needs more thought before we introduce this again such as...abstract rowID(item: T)method which normalizes a unique key we can cache against.repeathandles expandable rows and how Lit can keep track of optional interpolated entries while iterating<ak-table>is doing too much to make sense of and in need of detanglingWhy the
guarddirective?For some parts of the table render, our confidence in regularity is much higher. Parts like whether to render a checkbox, expandable area, etc. I'm sure there is more we can lean on but we can see how this fairs on a smaller space
Related PRs