providers/scim: fix PATCH for AWS#18230
Merged
BeryJu merged 2 commits intogoauthentik:mainfrom Nov 25, 2025
Merged
Conversation
✅ Deploy Preview for authentik-integrations canceled.
|
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs canceled.
|
BeryJu
reviewed
Nov 18, 2025
BeryJu
reviewed
Nov 25, 2025
Comment on lines
+133
to
+137
| match connection.provider.compatibility_mode: | ||
| case SCIMCompatibilityMode.AWS: | ||
| self._update_patch_aws(group, scim_group, connection) | ||
| case _: | ||
| self._update_patch_general(group, scim_group, connection) |
Member
There was a problem hiding this comment.
small nit, I think an if/else would be more readable for this but good either way
BeryJu
approved these changes
Nov 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18230 +/- ##
==========================================
+ Coverage 92.73% 92.90% +0.17%
==========================================
Files 869 869
Lines 48039 48152 +113
==========================================
+ Hits 44550 44738 +188
+ Misses 3489 3414 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kensternberg-authentik
added a commit
that referenced
this pull request
Dec 11, 2025
* main: (58 commits) core: bump goauthentik.io/api/v3 from 3.2025120.5 to 3.2025120.7 (#18381) web/admin: add entitlement search (#18291) core: bump goauthentik/fips-debian from `8b7e8d0` to `8c4ec98` (#18361) website: bump the build group in /website with 3 updates (#18382) core: bump astral-sh/uv from 0.9.11 to 0.9.12 (#18383) root: improve testing helpers (#18379) website: bump the goauthentik group across 1 directory with 4 updates (#18378) website: bump the eslint group in /website with 3 updates (#18356) policies: use flow planner directly in PolicyAccessView to directly set flow context (#18372) providers/scim: fix PATCH for AWS (#18230) enterprise/providers/scim: fix OAuth (#18358) web: Fix stale table rows (#17940) web: Bump packages. (#18371) *: convert slugfields to textfields (#17411) outposts: set container healthcheck inline (#18298) web: ESLint Typing Fixes (#18362) core: bump golang.org/x/crypto from 0.43.0 to 0.45.0 (#18275) lifecycle/aws: bump aws-cdk from 2.1032.0 to 2.1033.0 in /lifecycle/aws (#18278) core: bump github.com/getsentry/sentry-go from 0.38.0 to 0.39.0 (#18353) ci: bump actions/setup-python from 6.0.0 to 6.1.0 in /.github/actions/setup (#18360) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Resolves #12321
According to the AWS SCIM reference,
PatchGroupoperation must containpathfield with supported attributes: displayName, members, and externalId.The current PR enforces this behaviour based on SCIMCompatibilityMode.
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)