Skip to content

web: Table row refinements#17659

Merged
GirlBossRush merged 4 commits intomainfrom
fix-table-click-actions
Oct 23, 2025
Merged

web: Table row refinements#17659
GirlBossRush merged 4 commits intomainfrom
fix-table-click-actions

Conversation

@GirlBossRush
Copy link
Contributor

Details

This PR fixes several issues that occur when rendering table rows:

  • The "select all" checkbox now respects the clearOnRefresh property.
  • Selectable rows with expandable content now prefers expansion over selection when clicking a text cell.
  • Expandable content is now lazy-rendered
  • Lit's repeat directive is now used to have a more stable/performant rendering.

@GirlBossRush GirlBossRush requested a review from a team as a code owner October 22, 2025 21:06
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit b9112e6
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68f9488e5e169f0008f44069

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit b9112e6
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68f9488e0e5b2100094c75b2
😎 Deploy Preview https://deploy-preview-17659--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit b9112e6
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68f9488e44da070008524027

@GirlBossRush GirlBossRush added the area:frontend Features or issues related to the browser, TypeScript, Node.js, etc label Oct 22, 2025
@GirlBossRush GirlBossRush force-pushed the fix-table-click-actions branch from 6e164d0 to b9112e6 Compare October 22, 2025 21:11
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (b205e82) to head (b9112e6).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17659      +/-   ##
==========================================
- Coverage   92.97%   92.94%   -0.04%     
==========================================
  Files         869      869              
  Lines       47949    47949              
==========================================
- Hits        44581    44564      -17     
- Misses       3368     3385      +17     
Flag Coverage Δ
e2e 45.19% <ø> (-0.07%) ⬇️
integration 23.18% <ø> (+<0.01%) ⬆️
unit 91.07% <ø> (+<0.01%) ⬆️
unit-migrate 91.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b9112e621f175a093b5278b64458c80cd58e93f8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b9112e621f175a093b5278b64458c80cd58e93f8

Afterwards, run the upgrade commands from the latest release notes.

@GirlBossRush GirlBossRush merged commit 03f4d7a into main Oct 23, 2025
99 checks passed
@GirlBossRush GirlBossRush deleted the fix-table-click-actions branch October 23, 2025 13:42
GirlBossRush added a commit that referenced this pull request Nov 27, 2025
* web: Reset selection state after refresh.

* web: Only select row when not expandable.

* web: Only render expandable content when row is expanded.

* web: Use `repeat` directive.
rissson pushed a commit that referenced this pull request Nov 27, 2025
…8408)

* web: Table row refinements (#17659)

* web: Reset selection state after refresh.

* web: Only select row when not expandable.

* web: Only render expandable content when row is expanded.

* web: Use `repeat` directive.

* web: Fix nested pointer event detection.

* web: Fix issues surrounding stale table rows.

* Port row selector fix.

---------

Co-authored-by: Teffen Ellis <592134+GirlBossRush@users.noreply.github.com>
Co-authored-by: Teffen Ellis <teffen@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Features or issues related to the browser, TypeScript, Node.js, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants