Skip to content

stages/email_authenticator: Fix email mfa loop#16579

Merged
BeryJu merged 5 commits intomainfrom
fix/email_mfa_loop
Sep 16, 2025
Merged

stages/email_authenticator: Fix email mfa loop#16579
BeryJu merged 5 commits intomainfrom
fix/email_mfa_loop

Conversation

@melizeche
Copy link
Copy Markdown
Member

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

@melizeche melizeche requested a review from a team as a code owner September 3, 2025 05:20
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 3, 2025

Deploy Preview for authentik-integrations canceled.

Name Link
🔨 Latest commit b891171
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/68bad12973812a000797295b

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 3, 2025

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit b891171
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/68bad12907755000084927b8

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 3, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit b891171
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/68bad1298f56960008fb2d4f

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (dcc4a12) to head (b891171).
⚠️ Report is 165 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16579      +/-   ##
==========================================
+ Coverage   92.59%   92.83%   +0.23%     
==========================================
  Files         838      838              
  Lines       45304    45365      +61     
==========================================
+ Hits        41950    42115     +165     
+ Misses       3354     3250     -104     
Flag Coverage Δ
e2e 46.59% <0.00%> (+0.62%) ⬆️
integration 23.50% <0.00%> (-0.03%) ⬇️
unit 90.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melizeche melizeche changed the title satges/email_authenticator: Fix email mfa loop stages/email_authenticator: Fix email mfa loop Sep 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-b891171c568e794773f0e47f26fc37e987b3f6b9
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-b891171c568e794773f0e47f26fc37e987b3f6b9

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu added the backport/version-2025.8 Add this label to PRs to backport changes to version-2025.8 label Sep 4, 2025
@melizeche melizeche requested a review from BeryJu September 5, 2025 12:07
@BeryJu BeryJu merged commit b0a508a into main Sep 16, 2025
108 checks passed
@BeryJu BeryJu deleted the fix/email_mfa_loop branch September 16, 2025 14:04
authentik-automation bot pushed a commit that referenced this pull request Sep 16, 2025
* Return error message instead of infinite loop

* Remove unused code

* check for existing email device

* revert to initial behaviour

* Add test for failing when the user already has an email device
@authentik-automation
Copy link
Copy Markdown
Contributor

🍒 Cherry-pick to version-2025.8 created: #16807

BeryJu pushed a commit that referenced this pull request Sep 16, 2025
…16807)

stages/email_authenticator: Fix email mfa loop (#16579)

* Return error message instead of infinite loop

* Remove unused code

* check for existing email device

* revert to initial behaviour

* Add test for failing when the user already has an email device

Co-authored-by: Marcelo Elizeche Landó <marcelo@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Sep 19, 2025
* main: (81 commits)
  translate: Updates for file web/xliff/en.xlf in de (#16808)
  stages: update friendly_name model from null to blank (#16672)
  sources/saml: add default error messages to exceptions (#15562)
  website/docs: 2025.8.3 release notes (#16809)
  core, web: update translations (#16783)
  stages/email_authenticator: Fix email mfa loop (#16579)
  website/docs: updated Frontend development environment contributor docs (#16731)
  webiste/integrations: update roundcube doc (#16753)
  website/docs: update create oauth provider page (#16617)
  website: bump @types/node from 24.4.0 to 24.5.0 in /website (#16789)
  web: bump the rollup group across 1 directory with 4 updates (#16792)
  core: bump github.com/getsentry/sentry-go from 0.35.2 to 0.35.3 (#16786)
  web: bump the storybook group across 1 directory with 5 updates (#16791)
  web: bump @types/node from 24.4.0 to 24.5.0 in /packages/esbuild-plugin-live-reload (#16794)
  web: bump @goauthentik/prettier-config from 1.0.5 to 3.1.0 in /web in the goauthentik group across 1 directory (#16793)
  web: bump @types/node from 24.4.0 to 24.5.0 in /packages/prettier-config (#16795)
  web: bump @types/node from 22.15.19 to 24.5.0 in /web (#16796)
  web: Use curated dictionary for e2e fixtures. (#16750)
  website/integrations: fix wekan redirect URL (#16801)
  website/docs: fix docker tabs not rendering properly (#16799)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/version-2025.8 Add this label to PRs to backport changes to version-2025.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants