Skip to content

sources/saml: add default error messages to exceptions#15562

Merged
PeshekDotDev merged 1 commit intogoauthentik:mainfrom
PeshekDotDev:samlexception
Sep 16, 2025
Merged

sources/saml: add default error messages to exceptions#15562
PeshekDotDev merged 1 commit intogoauthentik:mainfrom
PeshekDotDev:samlexception

Conversation

@PeshekDotDev
Copy link
Contributor

@PeshekDotDev PeshekDotDev commented Jul 15, 2025

Details

Gives default message for saml exceptions and allows for adding custom error messages as well

closes #13598

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@PeshekDotDev PeshekDotDev requested a review from a team as a code owner July 15, 2025 01:30
@netlify
Copy link

netlify bot commented Jul 15, 2025 •
edited
Loading

✅ Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit c32c9cc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/6877ca55dfde040008ea6686

@netlify
Copy link

netlify bot commented Jul 15, 2025 •
edited
Loading

✅ Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit c32c9cc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6877ca55dc24cb0008bbedfa

@netlify
Copy link

netlify bot commented Jul 15, 2025 •
edited
Loading

✅ Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit c32c9cc
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/6877ca55be55110008933124
😎 Deploy Preview https://deploy-preview-15562--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.16%. Comparing base (f836c38) to head (c32c9cc).
⚠️ Report is 798 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15562   +/-   ##
=======================================
  Coverage   93.15%   93.16%           
=======================================
  Files         831      831           
  Lines       44135    44146   +11     
=======================================
+ Hits        41114    41127   +13     
+ Misses       3021     3019    -2
Flag Coverage Δ
e2e 46.63% <100.00%> (-0.01%) ⬇️
integration 23.48% <0.00%> (-0.02%) ⬇️
unit 91.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson changed the title sources/saml add default error messages to exceptions sources/saml: add default error messages to exceptions Jul 15, 2025
@cheggerdev
Copy link

cheggerdev commented Jul 18, 2025

Thank you for fixing this issue.

@PeshekDotDev
Copy link
Contributor Author

PeshekDotDev commented Jul 20, 2025

Anytime @cheggerdev

@cheggerdev
Copy link

cheggerdev commented Jul 23, 2025 •
edited
Loading

@rissson @BeryJu Please review this PR

Would you mind to cherry-pick this to 2025.6.x release branch ?

@rissson
Copy link
Member

rissson commented Jul 23, 2025

We don't cherry pick those sort of changes to previous versions.

@cheggerdev
Copy link

cheggerdev commented Jul 25, 2025

We don't cherry pick those sort of changes to previous versions.

It would be really nice and helpful when this will go into 2025.8

@cheggerdev cheggerdev mentioned this pull request Aug 5, 2025
Closed
@cheggerdev
Copy link

cheggerdev commented Aug 14, 2025

The 2025.8 branch has been opened. Can this PR go into it, please ?

@PeshekDotDev
Copy link
Contributor Author

PeshekDotDev commented Aug 18, 2025 •
edited
Loading

@cheggerdev are you running into a SAML error right now that you need this to debug? If you message me on discord, I can try and help you debug your problem. I've played with zabbix a bit while testing some integrations so I might have a little context

@cheggerdev
Copy link

cheggerdev commented Aug 18, 2025 •
edited
Loading

@cheggerdev are you running into a SAML error right now that you need this to debug? If you message me on discord — peshekdotdev — I can try and help you debug your problem. I've played with zabbix a bit while testing some integrations so I might have a little context

@ConzorKingKong I still run into a SAML error.
I use a Let's Encrypt certificate issued with acme.sh --ecc.
My current theory is that authentik saml cannot deal with ECC certificates but with RSA only. See issue #15412
authentik oauth works with ECC certificate.

@PeshekDotDev
Copy link
Contributor Author

PeshekDotDev commented Sep 8, 2025

Just posting here to let a code reviewer know that the issue mentioned above has been solved

@cheggerdev
Copy link

cheggerdev commented Sep 12, 2025

We don't cherry pick those sort of changes to previous versions.

Now that the backport part has been improved does this still count?

@rissson rissson requested review from a team and BeryJu September 15, 2025 11:05
@PeshekDotDev PeshekDotDev merged commit 7abd287 into goauthentik:main Sep 16, 2025
104 checks passed
kensternberg-authentik added a commit that referenced this pull request Sep 19, 2025
@kensternberg-authentik
Merge branch 'main' into dev
d0daec4 
* main: (81 commits)
  translate: Updates for file web/xliff/en.xlf in de (#16808)
  stages: update friendly_name model from null to blank (#16672)
  sources/saml: add default error messages to exceptions (#15562)
  website/docs: 2025.8.3 release notes (#16809)
  core, web: update translations (#16783)
  stages/email_authenticator: Fix email mfa loop (#16579)
  website/docs: updated Frontend development environment contributor docs (#16731)
  webiste/integrations: update roundcube doc (#16753)
  website/docs: update create oauth provider page (#16617)
  website: bump @types/node from 24.4.0 to 24.5.0 in /website (#16789)
  web: bump the rollup group across 1 directory with 4 updates (#16792)
  core: bump github.com/getsentry/sentry-go from 0.35.2 to 0.35.3 (#16786)
  web: bump the storybook group across 1 directory with 5 updates (#16791)
  web: bump @types/node from 24.4.0 to 24.5.0 in /packages/esbuild-plugin-live-reload (#16794)
  web: bump @goauthentik/prettier-config from 1.0.5 to 3.1.0 in /web in the goauthentik group across 1 directory (#16793)
  web: bump @types/node from 24.4.0 to 24.5.0 in /packages/prettier-config (#16795)
  web: bump @types/node from 22.15.19 to 24.5.0 in /web (#16796)
  web: Use curated dictionary for e2e fixtures. (#16750)
  website/integrations: fix wekan redirect URL (#16801)
  website/docs: fix docker tabs not rendering properly (#16799)
  ...
@PeshekDotDev PeshekDotDev deleted the samlexception branch January 26, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rissson rissson rissson approved these changes

@BeryJu BeryJu Awaiting requested review from BeryJu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SAMLException unclear because of empty string.

3 participants

@PeshekDotDev @cheggerdev @rissson