web/flow: cleanup WebAuthn helper functions#14460
Merged
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
72efb90 to
b116a03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #14460 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 815 815
Lines 42122 42122
=======================================
+ Hits 39073 39074 +1
+ Misses 3049 3048 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f561400e85a78d8cc906f24a2387085a12cef318
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-f561400e85a78d8cc906f24a2387085a12cef318Afterwards, run the upgrade commands from the latest release notes. |
b116a03 to
c70f85a
Compare
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Jun 16, 2025
* main: (43 commits) Web/cleanup/empty state better slot handling (#14289) website/docs: release notes for `2025.6.2` (#15065) website/docs: remove commented out config options (#15064) website/docs: postgres troubleshooting: get PGPASSWORD from POSTGRES_PASSWORD_FILE (#15039) core: bump goauthentik/fips-python from 3.13.4-slim-bookworm-fips to 3.13.5-slim-bookworm-fips (#15058) website: bump the eslint group in /website with 2 updates (#15059) web: bump the wdio group across 1 directory with 3 updates (#14593) web: bump @sentry/browser from 9.28.1 to 9.29.0 in /web in the sentry group across 1 directory (#15061) web: bump the eslint group across 2 directories with 2 updates (#15062) core: bump axllent/mailpit from v1.26.0 to v1.26.1 in /tests/e2e (#15060) core: bump pydantic from 2.11.5 to 2.11.7 (#15063) providers/oauth2: bug fixes from conformance testing (#15056) website/integrations: change nextcloud scope name to avoid confusion (#15050) web/flow: cleanup WebAuthn helper functions (#14460) web/elements: fix typo in localeComparator (#15054) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#15049) translate: Updates for file locale/en/LC_MESSAGES/django.po in es (#15047) core, web: update translations (#15048) blueprints: add section support for organisation (#15045) core, web: update translations (#15043) ...
6 tasks
BeryJu
added a commit
that referenced
this pull request
Jun 20, 2025
This reverts commit e86c40a. Signed-off-by: Jens Langhammer <jens@goauthentik.io> # Conflicts: # web/package-lock.json
BeryJu
added a commit
that referenced
this pull request
Jun 20, 2025
cavefire
pushed a commit
to cavefire/authentik
that referenced
this pull request
Jun 24, 2025
* pass goauthentik#1 Signed-off-by: Jens Langhammer <jens@goauthentik.io> * pass goauthentik#2 Signed-off-by: Jens Langhammer <jens@goauthentik.io> * add polyfill Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
cavefire
pushed a commit
to cavefire/authentik
that referenced
this pull request
Jun 24, 2025
…" (goauthentik#15172) Revert "web/flow: cleanup WebAuthn helper functions (goauthentik#14460)" This reverts commit e86c40a. Signed-off-by: Jens Langhammer <jens@goauthentik.io> # Conflicts: # web/package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Remove utility functions we had as they are built in to the browser now
Requires #14461 to make sure nothing is broken, but local testing works fine
Seems like a lot of these APIs are only available on the latest Safari (18.4), which came out in late march...so we'll probably have to pull in this polyfill: https://github.com/MasterKale/webauthn-polyfills
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)